feat: add User-Agent header to all outbound HTTP requests #37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add explicit User-Agent header to all HTTP requests made by the SDK. The header follows the format: flagsmith-rust-sdk/<version> Implementation details: - Created get_user_agent() function that reads version from CARGO_PKG_VERSION at compile time using option_env! macro - Falls back to "flagsmith-rust-sdk/unknown" if version unavailable - User-Agent header is added to default headers in Flagsmith client constructor - Header is automatically included in both API requests and analytics calls Testing: - Added test_get_user_agent_format() to verify the function returns correct format and actual version (not "unknown") during cargo test - Added test_user_agent_header_is_set() to verify the header is sent in HTTP requests using httpmock
khvn26
approved these changes
Nov 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add explicit User-Agent header to all HTTP requests made by the SDK.
The header follows the format: flagsmith-rust-sdk/
Implementation details:
Testing:
Added test_get_user_agent_format() to verify the function returns correct format and actual version (not "unknown") during cargo test
Added test_user_agent_header_is_set() to verify the header is sent in HTTP requests using httpmock
Manual Testing:
To verify the User-Agent header implementation, we created a standalone Rust application that uses the SDK to make API calls. The headers received by the test server are shown below: