fix: address review comment

Author: existentialcoder

api/conftest.py

@@ -555,10 +555,6 @@ def api_client() -> APIClient:
 def feature(project: Project) -> Feature:
     return Feature.objects.create(name="Test Feature1", project=project)  # type: ignore[no-any-return]
 
-@pytest.fixture()
-def feauture_with_dots(project: Project) -> Feature:
-    return Feature.objects.create(name="feature.name", project=project)  # type: ignore[no-any-return]
-
 
 @pytest.fixture()
 def change_request(environment: Environment, admin_user: FFAdminUser) -> ChangeRequest:

api/tests/unit/app_analytics/test_unit_app_analytics_views.py

@@ -18,13 +18,17 @@
 from app_analytics.models import FeatureEvaluationRaw
 from environments.identities.models import Identity
 from environments.models import Environment
+from api.integrations.launch_darkly.types import Project
 from features.models import Feature
 from organisations.models import (
     Organisation,
     OrganisationSubscriptionInformationCache,
 )
 from tests.types import EnableFeaturesFixture
 
+@pytest.fixture()
+def feature_with_dots(project: Project) -> Feature:
+    return Feature.objects.create(name="feature.with.dots", project=project)  # type: ignore[no-any-return]
 
 def test_sdk_analytics_ignores_bad_data(
     mocker: MockerFixture,
@@ -61,13 +65,13 @@ def test_sdk_analytics_ignores_bad_data(
 def test_sdk_analytics_ignores_feature_data_with_dots(
     mocker: MockerFixture,
     environment: Environment,
-    feauture_with_dots: Feature,
+    feature_with_dots: Feature,
     api_client: APIClient,
 ) -> None:
     # Given
     api_client.credentials(HTTP_X_ENVIRONMENT_KEY=environment.api_key)
 
-    data = { feauture_with_dots.name: 20 }
+    data = { feature_with_dots.name: 20 }
     mocked_feature_eval_cache = mocker.patch(
         "app_analytics.views.feature_evaluation_cache"
     )
@@ -85,8 +89,8 @@ def test_sdk_analytics_ignores_feature_data_with_dots(
 
     mocked_feature_eval_cache.track_feature_evaluation.assert_called_once_with(
         environment_id=environment.id,
-        feature_name=feauture_with_dots.name,
-        evaluation_count=data[feauture_with_dots.name],
+        feature_name=feature_with_dots.name,
+        evaluation_count=data[feature_with_dots.name],
         labels={},
     )