docs: Node.js v5 docs #4821
Merged
docs: Node.js v5 docs #4821
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"Node.js" instead of "NodeJS" Node 18 version bump Don't be cool and use "npm i", --save is also not needed in modern npm ES6 syntax
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
matthewelwell
approved these changes
Nov 28, 2024
Comment on lines
+378
to
+379
| const showButton = flags.isFeatureEnabled('secret_button'); | ||
| const buttonData = flags.getFeatureValue('secret_button'); |
There was a problem hiding this comment.
If we're changing this here, we should also do it here for consistency.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR! Please check the boxes below:
docs/if required so people know about the feature!Changes
Fixes Node.js to use the latest version (v4).
This change depends on Flagsmith/flagsmith-nodejs-client#166 and Flagsmith/flagsmith-nodejs-client#165 to be released.
Committed with--no-verifysince I couldn't get prettier to stop breaking my code after reformatting. This breaks this PR and I haven't had time to fix it.How did you test this code?
Docs built locally, code snippets typechecked with an editor but not actually runtime tested.