-
Notifications
You must be signed in to change notification settings - Fork 458
feat: Allow task processor to have its own database #5406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 3 Skipped Deployments
|
|
Uffizzi Preview |
9e7caa8 to
f29b8bd
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5406 +/- ##
=======================================
Coverage 97.65% 97.65%
=======================================
Files 1235 1235
Lines 43326 43334 +8
=======================================
+ Hits 42309 42317 +8
Misses 1017 1017 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, but there are a couple of general comments:
- I'd love to see in the description confirmation that this has been tested manually
- We should add these new settings to the docs
Docker builds report
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me now 👍
Fixes #5136.
docs/if required so people know about the feature!Changes
Based on the original issue (#5136) description.
Configures support to multi-database task processor as implemented in Flagsmith/flagsmith-common#68.
Defaults to consuming from both databases to ensure remaining tasks from
'default'are processed. Introduced configuration + documentation [intend to] make it easy to disable/fine-tune this behavior in favor of performance.How did you test this code?
Test logs
TEST 1: No task processor database
Current functionality is kept intact.
TEST 2: Task processor database introduced
Task processor now consumes from both
defaultandtask_processordatabases, in that order.unset TASK_PROCESSOR_DATABASES DATABASE_URL=postgres://postgres@database:5432/postgres TASK_PROCESSOR_DATABASE_URL=postgres://postgres@task-processor-database:5432/postgres /app/scripts/run-docker.sh run-task-processorTEST 3: Task processor database only
Task processor now consumes from
task_processordatabase only.