Skip to content

Conversation

@emyller
Copy link
Contributor

@emyller emyller commented Jul 16, 2025

Contributes to #5769.

  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

  • Move SegmentSerializer, RuleSerializer, and ConditionSerializer back to the core API code. They were moved in the past, and have since evolved.
  • Delete custom logic to handle nested objects in favor of WritableNestedModelSerializer.

How did you test this code?

Replaced multiple organs, patient walked out smiling.

  • Double check test coverage.

@emyller emyller self-assigned this Jul 16, 2025
@vercel
Copy link

vercel bot commented Jul 16, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Visit Preview Aug 5, 2025 7:22pm
flagsmith-frontend-preview ⬜️ Ignored (Inspect) Visit Preview Aug 5, 2025 7:22pm
flagsmith-frontend-staging ⬜️ Ignored (Inspect) Visit Preview Aug 5, 2025 7:22pm

@github-actions github-actions bot added api Issue related to the REST API chore labels Jul 16, 2025
@emyller emyller force-pushed the chore/move-segments-serializer-back-to-core branch from 4cd523e to caa14bb Compare July 21, 2025 21:40
@github-actions github-actions bot added chore and removed chore labels Jul 21, 2025
@codecov
Copy link

codecov bot commented Jul 21, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.83%. Comparing base (63f943a) to head (a36ed53).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5775   +/-   ##
=======================================
  Coverage   97.82%   97.83%           
=======================================
  Files        1258     1259    +1     
  Lines       44846    44904   +58     
=======================================
+ Hits        43872    43932   +60     
+ Misses        974      972    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions github-actions bot added chore and removed chore labels Jul 21, 2025
@emyller emyller marked this pull request as ready for review July 21, 2025 22:55
@emyller emyller requested a review from a team as a code owner July 21, 2025 22:55
@emyller emyller requested review from khvn26 and removed request for a team July 21, 2025 22:55
@github-actions github-actions bot added chore and removed chore labels Jul 21, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jul 21, 2025

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-e2e:pr-5775 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api-test:pr-5775 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-5775 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-frontend:pr-5775 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-5775 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-5775 Finished ✅ Results

@github-actions github-actions bot added the chore label Aug 5, 2025
khvn26
khvn26 previously approved these changes Aug 5, 2025
Copy link
Contributor

@matthewelwell matthewelwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good on the whole - definitely cleaner than it was, so nice work! I've added a couple of questions, but nothing that I'd be concerned will present any blockers.

@github-actions github-actions bot added chore and removed chore labels Aug 5, 2025
@github-actions github-actions bot added chore and removed chore labels Aug 5, 2025
@github-actions github-actions bot added chore and removed chore labels Aug 5, 2025
khvn26
khvn26 previously approved these changes Aug 5, 2025
matthewelwell
matthewelwell previously approved these changes Aug 5, 2025
@emyller emyller dismissed stale reviews from matthewelwell and khvn26 via ad096a0 August 5, 2025 19:14
@github-actions github-actions bot added chore and removed chore labels Aug 5, 2025
@emyller emyller force-pushed the chore/move-segments-serializer-back-to-core branch from ad096a0 to a36ed53 Compare August 5, 2025 19:22
@github-actions github-actions bot added chore and removed chore labels Aug 5, 2025
@emyller emyller merged commit 367edf4 into main Aug 5, 2025
29 checks passed
@emyller emyller deleted the chore/move-segments-serializer-back-to-core branch August 5, 2025 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api Issue related to the REST API chore

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants