-
Notifications
You must be signed in to change notification settings - Fork 458
chore: Move SegmentSerializer and MetadataSerializer back to core API #5775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 3 Skipped Deployments
|
4cd523e to
caa14bb
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5775 +/- ##
=======================================
Coverage 97.82% 97.83%
=======================================
Files 1258 1259 +1
Lines 44846 44904 +58
=======================================
+ Hits 43872 43932 +60
+ Misses 974 972 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…erializer-back-to-core
Docker builds report
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good on the whole - definitely cleaner than it was, so nice work! I've added a couple of questions, but nothing that I'd be concerned will present any blockers.
ad096a0 to
a36ed53
Compare
Contributes to #5769.
I have added information todocs/if required so people know about the feature!Changes
SegmentSerializer,RuleSerializer, andConditionSerializerback to the core API code. They were moved in the past, and have since evolved.WritableNestedModelSerializer.How did you test this code?
Replaced multiple organs, patient walked out smiling.