Skip to content

Conversation

Zaimwa9
Copy link
Contributor

@Zaimwa9 Zaimwa9 commented Sep 30, 2025

Thanks for submitting a PR! Please check the boxes below:

  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

This PR aims to harmonize how we capture lead between self_hosted and saas into hubspot.
image

These flows are valid when the consent checkbox is ticked.

Before

  • On lead user signup -> POST /api/v1/onboarding/request/send/
  • send_onboarding_request_to_saas_flagsmith_task is dispatched, sending a request to our flagsmith SaaS instance
  • SaaS receives request and calls create_self_hosted_onboarding_lead
  • GetOrCreate company in hubspot
  • Calls hubspot contact API directly to create user with company association

After
One of the goal is to entirely rely on Hubspot to deal with the company creation/association (based on user domain name)

  • On lead user signup -> POST /api/v1/onboarding/request/send/ including hubspotutk cookie for attribution
  • send_onboarding_request_to_saas_flagsmith_task is dispatched, sending a request to our flagsmith SaaS instance without organisation data but with cookie
  • SaaS receives request and calls create_self_hosted_onboarding_lead
  • User entity is created and create_lead_form is send, along with hubspot cookie and the correct form id

How did you test this code?

Please describe.

@Zaimwa9 Zaimwa9 requested review from a team as code owners September 30, 2025 12:58
Copy link

vercel bot commented Sep 30, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
flagsmith-frontend-preview Ready Ready Preview Comment Oct 13, 2025 10:24am
flagsmith-frontend-staging Ready Ready Preview Comment Oct 13, 2025 10:24am
1 Skipped Deployment
Project Deployment Preview Comments Updated (UTC)
docs Ignored Ignored Preview Oct 13, 2025 10:24am

@Zaimwa9 Zaimwa9 requested review from emyller and kyle-ssg and removed request for a team September 30, 2025 12:58
@github-actions github-actions bot added front-end Issue related to the React Front End Dashboard api Issue related to the REST API feature New feature or request labels Sep 30, 2025
Copy link
Contributor

github-actions bot commented Sep 30, 2025

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api-test:pr-6117 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-e2e:pr-6117 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-6117 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-6117 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-6117 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-frontend:pr-6117 Finished ✅ Results

…ub.com:Flagsmith/flagsmith into feat/create-self-hosted-contact-with-lead-form
@github-actions github-actions bot added feature New feature or request and removed feature New feature or request labels Sep 30, 2025
Copy link

codecov bot commented Sep 30, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.00%. Comparing base (57f0e97) to head (7aef429).
⚠️ Report is 12 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6117   +/-   ##
=======================================
  Coverage   97.99%   98.00%           
=======================================
  Files        1278     1278           
  Lines       44927    44983   +56     
=======================================
+ Hits        44028    44084   +56     
  Misses        899      899           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions github-actions bot added feature New feature or request and removed feature New feature or request labels Oct 1, 2025
@github-actions github-actions bot added feature New feature or request and removed feature New feature or request labels Oct 13, 2025
…ub.com:Flagsmith/flagsmith into feat/create-self-hosted-contact-with-lead-form
@github-actions github-actions bot added feature New feature or request and removed feature New feature or request labels Oct 13, 2025
cursor[bot]

This comment was marked as outdated.

@Zaimwa9 Zaimwa9 requested a review from gagantrivedi October 13, 2025 08:49
@Zaimwa9 Zaimwa9 merged commit 547139a into main Oct 13, 2025
30 checks passed
@Zaimwa9 Zaimwa9 deleted the feat/create-self-hosted-contact-with-lead-form branch October 13, 2025 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api Issue related to the REST API feature New feature or request front-end Issue related to the React Front End Dashboard

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants