-
Notifications
You must be signed in to change notification settings - Fork 457
feat: create endpoint to get a flag multivariate options #6134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for GitHub. 3 Skipped Deployments
|
for more information, see https://pre-commit.ci
Docker builds report
|
…Flagsmith/flagsmith into feat/create-flag-mv-endpoint-for-vercel
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6134 +/- ##
=======================================
Coverage 97.99% 98.00%
=======================================
Files 1278 1278
Lines 44927 45005 +78
=======================================
+ Hits 44028 44106 +78
Misses 899 899 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
gagantrivedi
reviewed
Oct 8, 2025
gagantrivedi
approved these changes
Oct 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR! Please check the boxes below:
docs/
if required so people know about the feature!Changes
To meet Vercel requirements, we need to provide the list of MV values in order for their Flag Explorer to list them.
It is using the SDK under the hood so it is not possible to use private keys to GET the same endpoint as the platform.
Hence why the creation of an endpoint specifically for this case
/api/v1/flags/{featureID}/multivariate-options/
with environment key permission level to get the list of multivariate valuesResponse as follows, voluntarily sending the bare minimum:
Will be used as follows in vercel package (yet to be changed):
How did you test this code?