chore: Add identifier terminology #6220
Open
+68
−48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
github-actions
bot
added
front-end
Docker builds report
|
| <FormGroup className='mt-4'> | ||
| <Row space> | ||
| <p className='fs-small lh-sm mb-0'> | ||
| Identities can be re-added here or via one of our |
There was a problem hiding this comment.
I don't think this is particularly clear - I'm not sure what 'here' means.
I'd say let's be more explicit and go with something like:
"Deleting this identity will delete all of their stored traits, and any identity overrides that you have configured. The identity will be recreated if it is identified via your Flagsmith integration again. You can also recreate it in the dashboard here."
This feels a bit wordy now, so perhaps we can remove some of the details here, but I think we should err towards this, rather than the unclear statement we currently have here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR! Please check the boxes below:
docs/if required so people know about the feature!Changes
Since we're using the term "Identifier" as a trait in segment rules, we should do our best to have the term in our identity pages.
Moves delete identity to a danger zone, also removes uses of the word "user"
How did you test this code?
Checked delete identity still worked since this was moved to a danger zone.