-
Notifications
You must be signed in to change notification settings - Fork 458
feat: trigger FLAG_UPDATED webhooks for v2 versioning environments #6240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
gagantrivedi
wants to merge
1
commit into
main
Choose a base branch
from
fix/6191-fs-update-webhook
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+473
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub. 3 Skipped Deployments
|
Docker builds report
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6240 +/- ##
========================================
Coverage 98.01% 98.01%
========================================
Files 1278 1278
Lines 45178 45324 +146
========================================
+ Hits 44280 44426 +146
Misses 898 898 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
When a new version is published in v2 versioning environments, trigger FLAG_UPDATED webhooks for individual feature states that have changed, in addition to the existing NEW_VERSION_PUBLISHED webhook. This allows webhook consumers to receive granular per-feature updates in the same format as non-versioned environments. Changes: - Add get_updated_feature_states() method to EnvironmentFeatureVersion to detect changed feature states by comparing enabled and value fields - Trigger FLAG_UPDATED webhooks for each changed feature state before NEW_VERSION_PUBLISHED webhook in trigger_update_version_webhooks
a1d62b4 to
1fbb5a6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR! Please check the boxes below:
docs/if required so people know about the feature!Changes
When a new version is published in v2 versioning environments, trigger FLAG_UPDATED webhooks for individual feature states that have changed, in addition to the existing NEW_VERSION_PUBLISHED webhook. This allows webhook consumers to receive granular per-feature updates in the same format as non-versioned environments.
Changes:
How did you test this code?
Adds unit tests