-
Notifications
You must be signed in to change notification settings - Fork 458
chore(sales-dashboard): add multiselect to plan filter #6243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
matthewelwell
wants to merge
3
commits into
main
Choose a base branch
from
chore(sales-dashboard)/add-multiselect-to-plan-filter
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
chore(sales-dashboard): add multiselect to plan filter #6243
matthewelwell
wants to merge
3
commits into
main
from
chore(sales-dashboard)/add-multiselect-to-plan-filter
+25
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Docker builds report
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6243 +/- ##
=======================================
Coverage 98.01% 98.01%
=======================================
Files 1278 1278
Lines 45178 45183 +5
=======================================
+ Hits 44280 44285 +5
Misses 898 898 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…elect-to-plan-filter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Adds multiselect to the plan filter in the sales dashboard.
The reasoning behind doing this is to remove the free plan by default to reduce the impact of loading the sales dashboard.
How did you test this code?
Ran the sales dashboard locally and validated the behaviour.