feat: AKS + Helm example #8
Conversation
| api_domain = flagsmith.mycompany.com # Domain for the Flagsmith API | ||
| frontend_domain = api.flagsmith.mycompany.com # Domain for the Flagsmith app |
There was a problem hiding this comment.
Nit: feels like this are the wrong way around.
| api_domain = flagsmith.mycompany.com # Domain for the Flagsmith API | |
| frontend_domain = api.flagsmith.mycompany.com # Domain for the Flagsmith app | |
| api_domain = api.flagsmith.mycompany.com # Domain for the Flagsmith API | |
| frontend_domain = flagsmith.mycompany.com # Domain for the Flagsmith app |
|
|
||
| ## Deployment | ||
|
|
||
| ### Inputs |
There was a problem hiding this comment.
It would be good to indicate which of these are required. For example, it feels as though the flagsmith_on_flagsmith_api_key shouldn't be required.
| ```diff | ||
| locals { | ||
| flagsmith_api_docker_repository = "flagsmith/flagsmith-private-cloud" | ||
| + flagsmith_api_version = "3.0.0" |
There was a problem hiding this comment.
Not: seems odd that we're specifying 3.0.0 here when it doesn't exist (and we have no real major plans to do so). Not a major issue just feels a little odd.
| administrator_password = var.db_admin_password | ||
| zone = "1" | ||
| storage_mb = 32768 | ||
| sku_name = "MO_Standard_E4ds_v4" |
There was a problem hiding this comment.
Should this be an input?
| name = "${var.project_name}-db-server" | ||
| resource_group_name = azurerm_resource_group.default.name | ||
| location = azurerm_resource_group.default.location | ||
| version = "11" |
There was a problem hiding this comment.
We should bump this to 15
| set { | ||
| name = "frontend.extraEnv.FLAGSMITH_ON_FLAGSMITH_API_URL" | ||
| value = "https://${var.api_domain}/api/v1/" | ||
| } |
There was a problem hiding this comment.
I would love it if we could parameterise this somehow so that it's not required for people to set up flagmsith on flagsmith unless they have to?
| @@ -0,0 +1,105 @@ | |||
| locals { | |||
| flagsmith_api_docker_repository = "flagsmith/flagsmith-private-cloud" | |||
| flagsmith_api_version = "2.64.0" | |||
There was a problem hiding this comment.
Let's bump this to the latest - 2.96.0 I think?
| @@ -0,0 +1,105 @@ | |||
| locals { | |||
| flagsmith_api_docker_repository = "flagsmith/flagsmith-private-cloud" | |||
There was a problem hiding this comment.
Maybe this should default to flagsmith/flagsmith-api since it's open source?
| - flagsmith_api_version = "2.64.0" | ||
| } | ||
| ``` | ||
| 2. Change the frontend version in [helm/flagsmith-values.yaml](helm/flagsmith-values.yaml): |
There was a problem hiding this comment.
I'd like to understand why the frontend version is set in the values.yaml whereas the api version is set as a terraform variable?
|
|
||
| frontend: | ||
| image: | ||
| tag: 2.64.0 |
There was a problem hiding this comment.
Let's bump this to the latest version - 2.96.0 I think?
2 participants
Thanks for submitting a PR! Please check the boxes below:
Changes
This adds a fully working Terraform example for deploying Flagsmith on top of Azure's managed Kubernetes and Flexible Server PostgreSQL.
How did you test this code?
This code currently works to deploy Flagsmith for one of our private cloud customers.