Skip to content

Conversation

@ellellie
Copy link
Collaborator

Fairly simple update on the Minecraft side, just swapping getWorld<->getEntityWorld and getPos<->getEntityPos as needed. I also took the liberty to cleanup some unused code, mainly TextUtil.

On the buildscripts side, however, is the grunt of this PR:

  • Ripped out spotbugs and the lombok plugin, as these were not being used.
  • Updated loom to 1.12-SNAPSHOT to fix Fabric interface injection per the Stonecutter docs. This means first-time builds actually work now
  • In addition to the above, I cleaned up the buildscripts so that GitHub Actions actually works now. For now, I've removed any automatic publishing to Modrinth, but this sets out the basic work to do that.
  • There's a new buildAndCollect task which collects built jars into the build/libs/{version}/ directory. This should help with uploading new versions from hereon.

We should also look into migrating our buildscripts to the Kotlin DSL at some point as well per the recommendation by Stonecutter.

Removes the spotbugs and delombok steps, and updates fabric-loom to 1.12-SNAPSHOT to fix builds involving injected interfaces.
@ellellie ellellie requested a review from Flatkat October 27, 2025 10:08
@ellellie ellellie self-assigned this Oct 27, 2025
@vico93
Copy link

vico93 commented Oct 28, 2025

As someone migrating to 1.21.10, thank you so much for this @ellellie !!! Really appreciated your PR

@Flatkat
Copy link
Owner

Flatkat commented Nov 4, 2025

Ellie has been really saving my butt w these PRs and this patience during this period of burnout indeed, I really appreciate that.
I should try to get this out soon as a proper release but I should review and test it first

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants