Skip to content

Fixed first visible index issue #582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mohitjaindev wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixed first visible index issue #582

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "recyclerlistview",
"version": "3.0.5-beta.1",
"version": "3.0.10",
"description": "The listview that you need and deserve. It was built for performance, uses cell recycling to achieve smooth scrolling.",
"main": "dist/reactnative/index.js",
"types": "dist/reactnative/index.d.ts",
Expand Down
3 changes: 2 additions & 1 deletion src/utils/BinarySearch.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,8 @@ export default class BinarySearch {
let high = size - 1;
let mid = Math.floor((low + high) / 2);
let lastValue = 0;
let absoluteLastDiff = Math.abs(valueExtractor(mid) - targetValue);
const initialDiff = (valueExtractor(mid) - targetValue);
let absoluteLastDiff = initialDiff >= 0 ? initialDiff : Number.MAX_SAFE_INTEGER;
let result = mid;
let diff = 0;
let absoluteDiff = 0;
Expand Down