Skip to content

fix onLayout floating point numbers using roundToNearestPixel #794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Freddy03h wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix onLayout floating point numbers using roundToNearestPixel #794

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions src/platform/reactnative/scrollcomponent/ScrollComponent.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import {
NativeSyntheticEvent,
ScrollView,
View,
PixelRatio,
} from "react-native";
import BaseScrollComponent, { ScrollComponentProps } from "../../../core/scrollcomponent/BaseScrollComponent";
import TSCast from "../../../utils/TSCast";
Expand Down Expand Up @@ -114,9 +115,11 @@ export default class ScrollComponent extends BaseScrollComponent {
}

private _onLayout = (event: LayoutChangeEvent): void => {
if (this._height !== event.nativeEvent.layout.height || this._width !== event.nativeEvent.layout.width) {
this._height = event.nativeEvent.layout.height;
this._width = event.nativeEvent.layout.width;
const layoutHeight = PixelRatio.roundToNearestPixel(event.nativeEvent.layout.height);
const layoutWidth = PixelRatio.roundToNearestPixel(event.nativeEvent.layout.width);
if (this._height !== layoutHeight || this._width !== layoutWidth) {
this._height = layoutHeight;
this._width = layoutWidth;
if (this.props.onSizeChanged) {
this._isSizeChangedCalledOnce = true;
this.props.onSizeChanged(event.nativeEvent.layout);
Expand Down
12 changes: 7 additions & 5 deletions src/platform/reactnative/viewrenderer/ViewRenderer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import * as React from "react";
import { LayoutChangeEvent, View, ViewProperties } from "react-native";
import { LayoutChangeEvent, View, ViewProperties, PixelRatio } from "react-native";
import { Dimension } from "../../../core/dependencies/LayoutProvider";
import { LayoutManager } from "../../../core/layoutmanager/LayoutManager";
import BaseViewRenderer, { ViewRendererProps } from "../../../core/viewrenderer/BaseViewRenderer";
Expand Down Expand Up @@ -76,11 +76,13 @@ export default class ViewRenderer extends BaseViewRenderer<any> {
//Preventing layout thrashing in super fast scrolls where RN messes up onLayout event
const xDiff = Math.abs(this.props.x - event.nativeEvent.layout.x);
const yDiff = Math.abs(this.props.y - event.nativeEvent.layout.y);
const layoutHeight = PixelRatio.roundToNearestPixel(event.nativeEvent.layout.height);
const layoutWidth = PixelRatio.roundToNearestPixel(event.nativeEvent.layout.width);
if (xDiff < 1 && yDiff < 1 &&
(this.props.height !== event.nativeEvent.layout.height ||
this.props.width !== event.nativeEvent.layout.width)) {
this._dim.height = event.nativeEvent.layout.height;
this._dim.width = event.nativeEvent.layout.width;
(this.props.height !== layoutHeight ||
this.props.width !== layoutWidth)) {
this._dim.height = layoutHeight;
this._dim.width = layoutWidth;
if (this.props.onSizeChanged) {
this.props.onSizeChanged(this._dim, this.props.index);
}
Expand Down