Skip to content

Trail Table: Allow multi select #264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

slothful-vassal
Copy link
Contributor

@slothful-vassal slothful-vassal commented Apr 18, 2025

Hello,

I've tried to implement a multiselect option for trail table view. There are still some open issues:

  • missing 'Share'
  • missing 'Export'
  • horizontal scroll bar
  • missing localizations

This "pull request" is a prototype to check out, if this is a feature, which complains with your plans to improve wanderer. If not, then I would stop here, before spending too much time ;)

Let me know, what you think about it.
Bildschirmfoto vom 2025-04-18 19-14-52

Many thanks.

#200

@Flomp
Copy link
Owner

Flomp commented Apr 26, 2025

Hey there,

thanks for the PR. I've also thought about doing it this way. I just find it a bit unintuitive having to switch to table mode before being able to multi-select. Ideally, this would be available in all 3 view modes. But I haven't had a great idea how to make this look nice/user-friendly.

@slothful-vassal
Copy link
Contributor Author

Hi,

you're totally right.
You know immich? There, when hovering over the items (photos in this case), a select button appears. Something like:
image

@slothful-vassal
Copy link
Contributor Author

I've added multi-select to cards view. Next step would be list view.
Still open are the issues mentioned in my first comment

  • multiple share is not working if some of the selected trails are already part of the list

@slothful-vassal
Copy link
Contributor Author

slothful-vassal commented May 7, 2025

Multiselect is now available in all view modes (cards, list, table).

Currently skipped for implementation for step 1:

  • multi share

@slothful-vassal
Copy link
Contributor Author

ready for review :)

@Flomp
Copy link
Owner

Flomp commented May 8, 2025

Hey man,
Thanks for all your work! I promise it does not go unnoticed. I'm currently working on getting wanderer into the fediverse (#215). This turned out to be quite the endeavour and will likely keep me busy for another week or two. Afterwards I'll get right to your PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants