Skip to content

Fix "Optimize for Tree Style Tab" #2270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
qoyie wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −5
Open

Fix "Optimize for Tree Style Tab" #2270

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions browser-features/chrome/common/ui-custom/styles/css/options/treestyletab.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
vbox#sidebar-box[sidebarcommand="treestyletab_piro_sakura_ne_jp-sidebar-action"] {
position: relative !important;
clip-path: inset(0) !important;
z-index: 1 !important;
z-index: 1000 !important;
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Jan 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

z-indexにマジックナンバー1000が直接使用されています。このファイルでは他の値がCSSカスタムプロパティとして:rootで定義されているため、一貫性のためにz-indexも同様に変数として定義することを検討してください。

例えば、:rootに--treestyletab-z-index: 1000;を追加し、ここではz-index: var(--treestyletab-z-index) !important;のように参照します。これにより、値の意図が明確になり、将来のメンテナンスが容易になります。

}

/*close*/
Expand Down Expand Up @@ -55,7 +55,3 @@ vbox#sidebar-box[sidebarcommand="treestyletab_piro_sakura_ne_jp-sidebar-action"]
(var(--max-treestyletab-size) - var(--min-treestyletab-size)) * -1
) !important;
}

#sidebar-box[sidebarcommand="treestyletab_piro_sakura_ne_jp-sidebar-action"] {
z-index: 1000 !important;
}