Loosen x509-parser bounds - #98
Merged
Merged
Conversation
This changes the bounds on the x509-parser crate to allow using the latest version (0.18.1). The new bounds specify _at least_ 0.16 (version in use currently) and _up to but excluding_ whatever next breaking version x509-parser may release. In other words: allows 0.16.x, 0.17.x, 0.18.x; excludes 0.19.
Contributor
Author
|
Note: I've verified that it builds fine with 0.17 & 0.18! |
pull Bot
pushed a commit
to mikeyhodl/ic
that referenced
this pull request
Jul 10, 2026
This bumps the version of x509-parser used directly by the codebase. We still have an old 0.16 version pulled transitively via ic-bn-lib and rustls-acme: FlorianUekermann/rustls-acme#98
nmattia
added a commit
to dfinity/ic
that referenced
this pull request
Aug 11, 2026
This includes our changes to loosen the bounds which allows us to drop some dependencies: FlorianUekermann/rustls-acme#98
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes the bounds on the x509-parser crate to allow using the latest version (0.18.1). The new bounds specify at least 0.16 (version in use currently) and up to but excluding whatever next breaking version x509-parser may release. In other words: allows 0.16.x, 0.17.x, 0.18.x; excludes 0.19.