-
-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump ToolGood.Words.Pinyin from 3.0.1.4 to 3.1.0 #1835
base: dev
Are you sure you want to change the base?
Conversation
Bumps [ToolGood.Words.Pinyin](https://github.com/toolgood/ToolGood.Words.Pinyin) from 3.0.1.4 to 3.1.0. - [Release notes](https://github.com/toolgood/ToolGood.Words.Pinyin/releases) - [Commits](https://github.com/toolgood/ToolGood.Words.Pinyin/commits) --- updated-dependencies: - dependency-name: ToolGood.Words.Pinyin dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
@check-spelling-bot Report🔴 Please reviewSee the 📂 files view or the 📜action log for details. Unrecognized words (2)automerge To accept ✔️ these unrecognized words as correct and remove the previously acknowledged and now absent words, run the following commands... in a clone of the [email protected]:Flow-Launcher/Flow.Launcher.git repository curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/main/apply.pl' |
perl - 'https://github.com/Flow-Launcher/Flow.Launcher/actions/runs/3990979238/attempts/1' To have the bot do this for you, reply quoting the following line: If the flagged items are 🤯 false positivesIf items relate to a ...
|
It does introduce a significant memory usage. Although I think it is acceptable, since that will only apply to people who uses pinyin (and it does provide better pinyin). |
|
around 100M I don't really know what exactly more pinyin is provided. Probably check the commit history? toolgood/ToolGood.Words.Pinyin@dcf03a4 |
I feel like maybe we should delay this upgrade unless there are some issue/missing pinyin, a 100mb increase is quite a lot and can be mistaken as flow itself taking up a lot of memory. What do you think? |
well sure |
Just converting this to draft until we actually need to bump it. |
Bumps ToolGood.Words.Pinyin from 3.0.1.4 to 3.1.0.
Commits
You can trigger a rebase of this PR by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)