Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Release Channel" Function #2017

Draft
wants to merge 11 commits into
base: dev
Choose a base branch
from

Conversation

onesounds
Copy link
Contributor

@onesounds onesounds commented Mar 30, 2023

image

What's the PR

Test Cases

  • Each channel's version should be able to be updated and changed to another version while in use.
  • The version you are using should be displayed correctly in the version display.

Todos

  • Actually update to the latest url
  • Able to update to latest prerelease
  • Able to detect version diff with latest prerelease

Done

  • Release Url is changed
  • Can detect latest release/prerelease release info

@jjw24 jjw24 marked this pull request as draft March 30, 2023 20:34
@taooceros taooceros marked this pull request as ready for review March 30, 2023 22:23
@onesounds onesounds changed the title "Update Source" Function "Release Channel" Function Mar 31, 2023
@onesounds onesounds added the enhancement New feature or request label Mar 31, 2023
@jjw24
Copy link
Member

jjw24 commented Apr 2, 2023

Are the todos done?

@VictoriousRaptor
Copy link
Contributor

IIRC we can't detect correct prerelease version with Squirrel? (semver v2 not supported by squirrel)

@jjw24
Copy link
Member

jjw24 commented Apr 23, 2023

Yeah ok, issues of Squirrel identified in #1547

@jjw24 jjw24 marked this pull request as draft April 23, 2023 21:41

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link

@check-spelling-bot Report

🔴 Please review

See the 📂 files view, the 📜action log, or 📝 job summary for details.

❌ Errors Count
❌ forbidden-pattern 22
⚠️ ignored-expect-variant 1
⚠️ non-alpha-in-dictionary 19

See ❌ Event descriptions for more information.

Using only_check_changed_files is incompatible with expect.txt.
To accept the items listed, you should add them to allow.txt.

If the flagged items are 🤯 false positives

If items relate to a ...

  • binary file (or some other file you wouldn't want to check at all).

    Please add a file path to the excludes.txt file matching the containing file.

    File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

    ^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

  • well-formed pattern.

    If you can write a pattern that would match it,
    try adding it to the patterns.txt file.

    Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

    Note that patterns can't match multiline strings.

@Jack251970
Copy link
Contributor

Jack251970 commented Mar 13, 2025

@jjw24 @VictoriousRaptor Any progress on switching to Clowd.Squirrel to be at a minimum properly version our prerelease builds?

@jjw24
Copy link
Member

jjw24 commented Mar 13, 2025

There is a PR tao has done and I outline a few issues that need to be addressed and further tested, if we can sort them out then we can start the migration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 min review enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants