Move log level to about page #3342

Jack251970 · 2025-03-13T04:55:05Z

Move log level card to about page since dev tools card is also here.

Jack251970 · 2025-03-13T04:55:50Z

@onesounds I really do not know which glyph should I choose for Log level. Could you please help me with it?

coderabbitai · 2025-03-13T04:57:18Z

📝 Walkthrough

Walkthrough

The changes introduce a new log level management feature in the SettingsPaneAbout view, including the addition of a LogLevelData class, properties for managing log levels, and a new UI component with a ComboBox for user selection. Conversely, the previous log level functionality in the SettingsPaneGeneral view is completely removed, affecting both the view model and associated UI elements.

Changes

File Group	Change Summary
`Flow.Launcher/SettingPages/ViewModels/SettingsPaneAboutViewModel.cs` `Flow.Launcher/SettingPages/Views/SettingsPaneAbout.xaml`	Added log level management. Introduced a new `LogLevelData` class, added `LogLevels` and `LogLevel` properties, implemented label updating via `UpdateEnumDropdownLocalizations()`, and added a new `cc:Card` with a ComboBox for log level selection.
`Flow.Launcher/SettingPages/ViewModels/SettingsPaneGeneralViewModel.cs` `Flow.Launcher/SettingPages/Views/SettingsPaneGeneral.xaml`	Removed log level management. Deleted the `LogLevelData` class, `LogLevels` and `LogLevel` properties, and removed the UI card containing the ComboBox that previously enabled log level selection.
`Flow.Launcher/Languages/en.xaml`	Updated localization strings. Corrected the capitalization of the "Log Level" string resource while re-adding it along with existing "Debug" and "Info" entries.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant ComboBox
    participant VM as SettingsPaneAboutViewModel
    participant Log
    User->>ComboBox: Open log level dropdown
    ComboBox->>VM: Retrieve LogLevels
    User->>ComboBox: Select new log level
    ComboBox->>VM: Update LogLevel property
    VM->>Log: SetLogLevel(newValue)
    VM->>VM: Update dropdown labels (UpdateEnumDropdownLocalizations)

Possibly related PRs

Flow-Launcher/Flow.Launcher#2739: Focuses on logging level management with similar UI and backend updates.

Suggested labels

no-pr-activity, 5 min review

Poem

Oh, I’m the rabbit with a codey beat,
Hopping through changes both swift and neat.
A dropdown for logs where values gleam,
And old panes fade like a fading dream.
Cheers to tweaks that make settings sweet!
🐇✨

Tip

⚡🧪 Multi-step agentic review comment chat (experimental)

We're introducing multi-step agentic chat in review comments. This experimental feature enhances review discussions with the CodeRabbit agentic chat by enabling advanced interactions, including the ability to create pull requests directly from comments.
- To enable this feature, set early_access to true under in the settings.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f24d64a and f96d88f.

📒 Files selected for processing (1)

Flow.Launcher/Languages/en.xaml (1 hunks)

✅ Files skipped from review due to trivial changes (1)

Flow.Launcher/Languages/en.xaml

⏰ Context from checks skipped due to timeout of 90000ms (3)

GitHub Check: gitStream.cm
GitHub Check: gitStream.cm
GitHub Check: gitStream.cm

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

coderabbitai

Actionable comments posted: 0

🧹 Nitpick comments (1)

Flow.Launcher/SettingPages/Views/SettingsPaneAbout.xaml (1)
126-132: Missing icon for consistency with other cards

The newly added log level card is missing an icon property, unlike other cards in this page. Consider adding an appropriate icon to maintain UI consistency.
-            <cc:Card Title="{DynamicResource logLevel}">
+            <cc:Card Title="{DynamicResource logLevel}" Icon="&#xE7BA;">
The suggested icon (E7BA) represents settings/configuration, but you can choose a more appropriate one from the icon set you're using.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 59b4859 and e8be131.

📒 Files selected for processing (4)

Flow.Launcher/SettingPages/ViewModels/SettingsPaneAboutViewModel.cs (2 hunks)
Flow.Launcher/SettingPages/ViewModels/SettingsPaneGeneralViewModel.cs (0 hunks)
Flow.Launcher/SettingPages/Views/SettingsPaneAbout.xaml (1 hunks)
Flow.Launcher/SettingPages/Views/SettingsPaneGeneral.xaml (0 hunks)

💤 Files with no reviewable changes (2)

Flow.Launcher/SettingPages/Views/SettingsPaneGeneral.xaml
Flow.Launcher/SettingPages/ViewModels/SettingsPaneGeneralViewModel.cs

⏰ Context from checks skipped due to timeout of 90000ms (3)

GitHub Check: gitStream.cm
GitHub Check: gitStream.cm
GitHub Check: gitStream.cm

🔇 Additional comments (6)

Flow.Launcher/SettingPages/ViewModels/SettingsPaneAboutViewModel.cs (6)

11-11: LGTM!

Appropriate namespace added for the Logger functionality.

49-49: LGTM!

Clean implementation of LogLevelData class that extends DropdownDataGeneric.

51-53: LGTM!

Proper initialization of LogLevels property using the standard pattern for dropdown data in this codebase.

54-66: LGTM!

Well-implemented LogLevel property with appropriate change detection before updating settings and log level.

72-73: LGTM!

Good addition of UpdateEnumDropdownLocalizations() call in the constructor to initialize dropdown labels.

75-78: LGTM!

Proper implementation of UpdateEnumDropdownLocalizations method to ensure dropdown labels are correctly displayed.

onesounds · 2025-03-13T05:03:25Z

@Jack251970

Jack251970 · 2025-03-13T05:07:03Z

@Jack251970

Thank you! Please check and review.

github-actions · 2025-03-13T05:14:11Z

@check-spelling-bot Report

🔴 Please review

See the 📂 files view, the 📜action log, or 📝 job summary for details.

❌ Errors	Count
❌ forbidden-pattern	22
⚠️ ignored-expect-variant	1
⚠️ non-alpha-in-dictionary	19

See ❌ Event descriptions for more information.

Using only_check_changed_files is incompatible with expect.txt.
To accept the items listed, you should add them to allow.txt.

If the flagged items are 🤯 false positives

If items relate to a ...

binary file (or some other file you wouldn't want to check at all).

Please add a file path to the excludes.txt file matching the containing file.

File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).
well-formed pattern.

If you can write a pattern that would match it,
try adding it to the patterns.txt file.

Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

Note that patterns can't match multiline strings.

Jack251970 · 2025-03-13T05:14:16Z

Sorry for any inconvenience. I forgot to change the related strings.

onesounds · 2025-03-13T05:24:00Z

@VictoriousRaptor @Jack251970
For reference, I am planning to create an "advanced" settings page to consolidate various options, such as log level, speed, sound selection, shadow settings, proxy, and other features that are generally not needed. This page could be added as a navigation button in the sidebar or under the "about" section. There are no issues right now, but if you guys find the need to add such detailed options in the future, it would be good to keep this plan in mind. Since you are likely to handle this work if I attempt it or suddenly pass away 😇, I thought it would be best for you to be aware of it in advance.

Move log level to about page

e8be131

Jack251970 requested a review from onesounds March 13, 2025 04:55

github-actions bot assigned Jack251970 Mar 13, 2025

This comment has been minimized.

Sign in to view

coderabbitai bot reviewed Mar 13, 2025

View reviewed changes

Add log level glyph

f24d64a

This comment has been minimized.

Sign in to view

gitstream-cm bot added the 1 min review label Mar 13, 2025

onesounds previously approved these changes Mar 13, 2025

View reviewed changes

Fix strings

f96d88f

Jack251970 dismissed onesounds’s stale review via f96d88f March 13, 2025 05:13

Jack251970 requested a review from onesounds March 13, 2025 05:14

onesounds approved these changes Mar 13, 2025

View reviewed changes

Jack251970 merged commit 424b575 into Flow-Launcher:dev Mar 13, 2025
6 checks passed

jjw24 added Dev branch only An issue or fix for the Dev branch build and removed 1 min review labels Mar 13, 2025

jjw24 added this to the 1.20.0 milestone Mar 13, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Move log level to about page #3342

Move log level to about page #3342

Jack251970 commented Mar 13, 2025 •

edited

Loading

This comment has been minimized.

Jack251970 commented Mar 13, 2025 •

edited

Loading

coderabbitai bot commented Mar 13, 2025 •

edited

Loading

Walkthrough

Changes

Sequence Diagram(s)

Possibly related PRs

Suggested labels

Poem

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

coderabbitai bot left a comment

onesounds commented Mar 13, 2025 •

edited

Loading

Jack251970 commented Mar 13, 2025 •

edited

Loading

This comment has been minimized.

github-actions bot commented Mar 13, 2025

Jack251970 commented Mar 13, 2025 •

edited

Loading

onesounds commented Mar 13, 2025

Move log level to about page #3342

Move log level to about page #3342

Conversation

Jack251970 commented Mar 13, 2025 • edited Loading

Move log level card to about page since dev tools card is also here.

This comment has been minimized.

Jack251970 commented Mar 13, 2025 • edited Loading

coderabbitai bot commented Mar 13, 2025 • edited Loading

Walkthrough

Changes

Sequence Diagram(s)

Possibly related PRs

Suggested labels

Poem

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

coderabbitai bot left a comment

Choose a reason for hiding this comment

onesounds commented Mar 13, 2025 • edited Loading

Jack251970 commented Mar 13, 2025 • edited Loading

This comment has been minimized.

github-actions bot commented Mar 13, 2025

@check-spelling-bot Report

🔴 Please review

See the 📂 files view, the 📜action log, or 📝 job summary for details.

Jack251970 commented Mar 13, 2025 • edited Loading

onesounds commented Mar 13, 2025

Jack251970 commented Mar 13, 2025 •

edited

Loading

Jack251970 commented Mar 13, 2025 •

edited

Loading

coderabbitai bot commented Mar 13, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

onesounds commented Mar 13, 2025 •

edited

Loading

Jack251970 commented Mar 13, 2025 •

edited

Loading

Jack251970 commented Mar 13, 2025 •

edited

Loading