Fix hotkey initialization issue

[Jack251970]

We should not call RefreshHotkeyInterface here because DependencyProperty is not set yet, and it will be called in OnHotkeyChanged event or Hotkey setter later.

Also fix a local variable issue.

Follows on from #3354

[github-actions]

@check-spelling-bot Report

🔴 Please review

See the 📂 files view, the 📜action log, or 📝 job summary for details.

❌ Errors	Count
❌ forbidden-pattern	22
⚠️ ignored-expect-variant	1
⚠️ non-alpha-in-dictionary	19

See ❌ Event descriptions for more information.

If the flagged items are 🤯 false positives

If items relate to a ...

• binary file (or some other file you wouldn't want to check at all).

  Please add a file path to the excludes.txt file matching the containing file.

  File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

  ^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

• well-formed pattern.

  If you can write a pattern that would match it,
  try adding it to the patterns.txt file.

  Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

  Note that patterns can't match multiline strings.

[gitstream-cm]

Be a legend 🏆 by adding a before and after screenshot of the changes you made, especially if they are around UI/UX.

[coderabbitai]

📝 Walkthrough

Walkthrough

The changes update the HotkeyControl class by modifying the initialization and refresh logic for the hotkey interface. The call to RefreshHotkeyInterface in the constructor is now commented out to prevent premature execution before the dependency property is set. Instead, the refresh is triggered later via the OnHotkeyChanged event or through the hotkey setter. Additionally, the method now uses its parameter (hotkey) to create a new HotkeyModel, ensuring accurate context-sensitive updates.

Changes

File(s)	Change Summary
Flow.Launcher/HotkeyControl.xaml.cs	- Commented out the call to RefreshHotkeyInterface(Hotkey) in the constructor to defer execution until after the dependency property is set. - Modified RefreshHotkeyInterface to use the method parameter hotkey instead of the property Hotkey when instantiating a new HotkeyModel.

Sequence Diagram(s)

sequenceDiagram
    participant UI
    participant HotkeyControl
    participant HotkeyModel
    UI->>HotkeyControl: Set Hotkey property
    HotkeyControl-->>HotkeyControl: OnHotkeyChanged event triggered
    HotkeyControl->>HotkeyControl: RefreshHotkeyInterface(hotkey)
    HotkeyControl->>HotkeyModel: Create new HotkeyModel(hotkey)

Loading

Possibly related PRs

• Enable the use of Win hotkey to trigger flow #3262: Updates in the HotkeyControl class’s hotkey handling relate to similar changes made in the HotKeyMapper class, particularly for LWin/RWin key management.
• Fix custom query hotkey settings issue #3354: Adjustments in the RefreshHotkeyInterface method and its parameter usage align with modifications in hotkey initialization in the HotkeyControl class.

Suggested labels

1 min review

Suggested reviewers

• jjw24
• taooceros

Poem

Hop, hop, a change so grand,
I’m a rabbit with a code-filled plan.
Hotkeys refreshed when they’re due,
No premature calls—now the flow is true!
Coding carrots, one by one, 🥕
A joyful update, now time for fun!
Happy trails in every run!

Tip

⚡🧪 Multi-step agentic review comment chat (experimental)

• We're introducing multi-step agentic chat in review comments. This experimental feature enhances review discussions with the CodeRabbit agentic chat by enabling advanced interactions, including the ability to create pull requests directly from comments.
  - To enable this feature, set early_access to true under in the settings.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9d1e305 and 044dc2c.

📒 Files selected for processing (1)

• Flow.Launcher/HotkeyControl.xaml.cs (1 hunks)

🧰 Additional context used

🧬 Code Definitions (1)

Flow.Launcher/HotkeyControl.xaml.cs (1)

Flow.Launcher/HotkeyControlDialog.xaml.cs (1) (1)

• SetKeysToDisplay (122:190)

⏰ Context from checks skipped due to timeout of 90000ms (2)

• GitHub Check: gitStream.cm
• GitHub Check: gitStream.cm

🔇 Additional comments (2)

Flow.Launcher/HotkeyControl.xaml.cs (2)

217-218: Good fix for premature initialization issue.

Removing the call to RefreshHotkeyInterface from the constructor is correct. Calling it at this point would use an uninitialized Hotkey property since the DependencyProperty is not yet set. The added comments clearly explain the reasoning and where it will be called later.

---

223-224: Correctly using parameter instead of class property.

Good change to use the hotkey parameter instead of the Hotkey class property. This ensures that the method uses the value passed to it rather than potentially accessing an outdated class property value. This is particularly important during property change events when the class property might not yet reflect the new value.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.