Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Local favicon for bookmark plugin #3361

Draft
wants to merge 19 commits into
base: dev
Choose a base branch
from

Conversation

onesounds
Copy link
Contributor

@onesounds onesounds commented Mar 19, 2025

What's the PR

  • Show Favicon with bookmark plugin
  • Unlike previous PRs, there is no network lookup. Instead, it retrieves the Favicon from local bookmark data, caches it in Flow, and then loads it.
  • Copilot told me that the images retrieved from bookmark data are separately cached in Flow and loaded by matching them when a URL is queried.

TODO

Test Cases

  • Works fine Chromium, edge, firefox.

Known issue

  • From my testing, I confirmed that it works fine on Chrome, Edge, and Firefox. In Firefox and Edge, there is an issue where the image appears small when added to the bookmark bar. However, I verified that it works correctly when added to bookmarks instead of the bookmark bar. It seems that Firefox and Edge saves a smaller image when adding it to the bookmark bar.
  • I'm not sure if I applied the NuGet package correctly. It has been applied to all .csproj files, but someone needs to check if it was applied only where necessary.
  • Flow may need an internal process to clear the bookmark plugin's favicon cache.

This comment has been minimized.

@Yusyuriv Yusyuriv self-requested a review March 19, 2025 20:23
@Yusyuriv Yusyuriv added the enhancement New feature or request label Mar 19, 2025
@Jack251970
Copy link
Contributor

@onesounds Similar to #3079? Should we close it?

This comment has been minimized.

This comment has been minimized.

@onesounds
Copy link
Contributor Author

onesounds commented Mar 20, 2025

@onesounds Similar to #3079? Should we close it?

I made it to do that.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

- Changed nuget for SVG
- Changed SVG code
Copy link

@check-spelling-bot Report

🔴 Please review

See the 📂 files view, the 📜action log, or 📝 job summary for details.

❌ Errors Count
❌ forbidden-pattern 22
⚠️ ignored-expect-variant 1
⚠️ non-alpha-in-dictionary 19

See ❌ Event descriptions for more information.

If the flagged items are 🤯 false positives

If items relate to a ...

  • binary file (or some other file you wouldn't want to check at all).

    Please add a file path to the excludes.txt file matching the containing file.

    File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

    ^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

  • well-formed pattern.

    If you can write a pattern that would match it,
    try adding it to the patterns.txt file.

    Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

    Note that patterns can't match multiline strings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
20 min review enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants