Fix Plugin Manager Issue

[Jack251970]

When we call other functions that need AllPlugins, we should put them after PluginManager.LoadPlugins(_settings.PluginSettings);.

• Since FL introduces dependency injection Introduce Dependency Injection for Better Development Experience #3175, the constructor of MainViewModel is brought forward because PublicAPIInstance needs its instance, so we cannot put RegisterResultsUpdatedEvent() in its constructor.
• Since Ioc.Default.GetRequiredService<Internationalization>().ChangeLanguage(_settings.Language); needs to check plugins with IPluginI18n interface, it should be put after Ioc.Default.GetRequiredService<MainViewModel>().RegisterResultsUpdatedEvent();

[gitstream-cm]

🥷 Code experts: onesounds

Jack251970, onesounds have most 👩‍💻 activity in the files.
Jack251970 has most 🧠 knowledge in the files.

See details

Flow.Launcher/App.xaml.cs

Activity based on git-commit:

	Jack251970	onesounds
MAR	17 additions & 28 deletions
FEB	79 additions & 40 deletions
JAN	86 additions & 66 deletions
DEC
NOV
OCT

Knowledge based on git-blame:
Jack251970: 42%

Flow.Launcher/ViewModel/MainViewModel.cs

Activity based on git-commit:

	Jack251970	onesounds
MAR	116 additions & 156 deletions	236 additions & 183 deletions
FEB	63 additions & 21 deletions	23 additions & 25 deletions
JAN	17 additions & 21 deletions
DEC	59 additions & 63 deletions
NOV	39 additions & 15 deletions
OCT

Knowledge based on git-blame:
Jack251970: 12%

To learn more about /:\ gitStream - Visit our Docs

[gitstream-cm]

Be a legend 🏆 by adding a before and after screenshot of the changes you made, especially if they are around UI/UX.

[github-actions]

@check-spelling-bot Report

🔴 Please review

See the 📂 files view, the 📜action log, or 📝 job summary for details.

❌ Errors	Count
❌ forbidden-pattern	22
⚠️ ignored-expect-variant	1
⚠️ non-alpha-in-dictionary	19

See ❌ Event descriptions for more information.

If the flagged items are 🤯 false positives

If items relate to a ...

• binary file (or some other file you wouldn't want to check at all).

  Please add a file path to the excludes.txt file matching the containing file.

  File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

  ^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

• well-formed pattern.

  If you can write a pattern that would match it,
  try adding it to the patterns.txt file.

  Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

  Note that patterns can't match multiline strings.

[coderabbitai]

📝 Walkthrough

Walkthrough

This pull request adjusts the application’s startup sequence and event registration. In the application’s main startup file, the plugin loading is moved to the beginning and followed by explicit registration of the ResultsUpdated event on the MainViewModel. In addition, the duplicate plugin load call is removed. In the MainViewModel, the call to register results updates is removed from the constructor and the RegisterResultsUpdatedEvent method is made public, allowing external invocation.

Changes

File(s)	Change Summary
Flow.Launcher/App.xaml.cs	Moved PluginManager.LoadPlugins(_settings.PluginSettings); to the top of the startup process; added registration of the ResultsUpdated event; removed duplicate call and repositioned comment.
Flow.Launcher/ViewModel/MainViewModel.cs	Removed call to RegisterResultsUpdatedEvent() from the constructor; modified RegisterResultsUpdatedEvent access from private to public.

Sequence Diagram(s)

sequenceDiagram
    participant App
    participant PluginManager
    participant MainViewModel

    App->>PluginManager: LoadPlugins(_settings.PluginSettings)
    PluginManager-->>App: Plugins Loaded
    App->>MainViewModel: RegisterResultsUpdatedEvent()

Loading

Possibly related PRs

• Fix issue that mainVM fails to work #3296: Modifies how the MainViewModel is instantiated in the PublicAPIInstance, directly relating to changes in initialization and event registration.
• Fix possible result update issue for plugins with IResultUpdate interface #3115: Alters the RegisterResultsUpdatedEvent method details in the MainViewModel, aligning closely with the changes in event call ordering.
• Fix API instance create twice issue & Make PluginManager.API private #3297: Involves removal of the event registration call within the MainViewModel constructor, correlating with the adjustments in event handling in the current PR.

Suggested labels

enhancement

Suggested reviewers

• jjw24
• taooceros

Poem

In the code garden at break of day,
I peek through lines where plugins play.
Events now ring as I leap with glee,
Streamlined paths set our programs free.
A bunny’s cheer in ASCII art—hop, skip, and code away!
🐇

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between dda008f and b75066f.

📒 Files selected for processing (2)

• Flow.Launcher/App.xaml.cs (1 hunks)
• Flow.Launcher/ViewModel/MainViewModel.cs (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (5)

• GitHub Check: gitStream.cm
• GitHub Check: gitStream.cm
• GitHub Check: gitStream.cm
• GitHub Check: gitStream.cm
• GitHub Check: gitStream.cm

🔇 Additional comments (2)

Flow.Launcher/App.xaml.cs (1)

130-136: Improved startup sequence order

The changes correctly reorder the operations during application startup to ensure proper initialization:

1. Load plugins first
2. Register ResultsUpdated event after plugins are loaded
3. Change language after both operations are complete

This addresses the core issue mentioned in the PR objectives, where functions requiring AllPlugins must be called after PluginManager.LoadPlugins.

Flow.Launcher/ViewModel/MainViewModel.cs (1)

215-215: Changed method accessibility from private to public

The RegisterResultsUpdatedEvent method has been made public to allow external invocation from the App startup sequence. This change properly supports the fix in the application startup flow, where this method is now explicitly called after plugin loading.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[taooceros]

actually maybe we can move this to PluginManager?

[Jack251970]

okay

[Jack251970]

oh we cannot do that. since PluginManager is in core project, it cannot access function in main project (MainViewModel.RegisterResultsUpdatedEvent)