History results display actual result icon for Last Opened history style #4057

jjw24 · 2025-10-17T23:44:39Z

Context:
Display icon on last history results

Follows on with #4042

Changes:

Fixed result highlighting and scrolling when switched to history mode
Changed the property flow uses to display icons, from IcoPath to new IcoPathAbsolute. This helps IcoPath be serializable while flow uses the constructed full path from IcoPathAbsolute.
Changed LastOpenedHistoryItem class to LastOpenedHistoryResult.
Introduced inheritance, LastOpenedHistoryResult is now a child of Result. This helps retaining properties from the Result class and not needing to new up the Result class every time to return results for display. LastOpenedHistoryResult and Result are now serializable, useful for future when we need to provide similar special Results that need to be saved to disk.
Fixed existing production preview issues where icons missing preview after history mode

Before

After

Tested

Results with the same query do not duplicate when saved
IcoPathAbsolute contains the full path
IcoPath updated from user selection when different
Moved flow to a different location and relative path images still work
History mode navigation behaves correctly

jjw24 · 2025-10-17T23:46:02Z

@Jack251970 @01Dri thoughts on showing the last opened with the actual result icon? Should it just show the icon instead of badge icon as well?

jjw24 · 2025-10-17T23:48:43Z

Also, there is a bug in the comparison logic when saving history results because as seen in the screenshot 'Save Settings' result shouldn't be duplicated.

01Dri · 2025-10-18T06:19:27Z

Also, there is a bug in the comparison logic when saving history results because as seen in the screenshot 'Save Settings' result shouldn't be duplicated.

It’s not really a bug. The equality comparison also uses the query, so in scenarios where I type “Ter” and open Terminal, and then type “Term” and open Terminal again, I end up with two history items “Ter” and “Term” both referring to the same application (Terminal), which causes duplicate results.

In Query style, that makes sense because the two queries are different.
However, in Last Opened style, it doesn’t really make sense.
A suggestion would be to filter the history items, removing duplicates by name and sorting them by the most recent execution date/time.
Here’s an example in MainViewModels.cs -> GetHistoryItems:

    foreach (var h in historyItems
               .OrderByDescending(x => x.ExecutedDateTime) 
               .DistinctBy(x => x.GetCompositeKey()).ToList())

CompositeKey (This name is just an example; it could be something else)

   public string GetCompositeKey()
    {
        var parts = new[] { Title, SubTitle, RecordKey }
            .Where(s => !string.IsNullOrEmpty(s));

        return string.Join("-", parts);
    }

01Dri · 2025-10-18T06:31:32Z

@Jack251970 @01Dri thoughts on showing the last opened with the actual result icon? Should it just show the icon instead of badge icon as well?

I think the icon with the badge is more intuitive for the user, as it indicates that the item is a history entry.

Jack251970 · 2025-10-18T06:59:38Z

Also, there is a bug in the comparison logic when saving history results because as seen in the screenshot 'Save Settings' result shouldn't be duplicated.

As 01Dri said, it is not a bug. Duplicated items will occur if you click A for many times.

Flow.Launcher/ViewModel/MainViewModel.cs

Flow.Launcher/Storage/QueryHistory.cs

Jack251970

Showing icons enhance users' experience and I agree with this change. But there is still something we need to resolve

jjw24 · 2025-10-18T07:47:42Z

@01Dri @Jack251970

I think the icon with the badge is more intuitive for the user, as it indicates that the item is a history entry.

What about just use the actual results icons, no badge?

However, in Last Opened style, it doesn’t really make sense.
A suggestion would be to filter the history items, removing duplicates by name and sorting them by the most recent execution date/time.

I think we should apply filtering of duplicates when last opened style is selected. What do you think?

Jack251970 · 2025-10-18T08:43:28Z

I think we should apply filtering of duplicates when last opened style is selected. What do you think?

@jjw24 I think we can do the filtering here as long as we keep the history in the order of execute time so that we can utilize the history list more effectively.

Flow.Launcher/Storage/QueryHistory.cs

01Dri · 2025-10-19T20:40:44Z

@Jack251970 @jjw24 Sorry for the question, I’m new to the open source community. My question is: am I allowed to make the requested changes, or is this PR only for jjw? Thanks!

Jack251970 · 2025-10-20T02:15:25Z

@Jack251970 @jjw24 Sorry for the question, I’m new to the open source community. My question is: am I allowed to make the requested changes, or is this PR only for jjw? Thanks!

You can create PR to last_history_show_result_icon branch

01Dri · 2025-10-20T03:06:21Z

@Jack251970 @jjw24 Sorry for the question, I’m new to the open source community. My question is: am I allowed to make the requested changes, or is this PR only for jjw? Thanks!

You can create PR to last_history_show_result_icon branch

Ok thanks!

jjw24 · 2025-10-20T07:51:03Z

@01Dri just to add, of course you can, just let the PR author know what/which area you are changing to avoid overlapping. If very minor like comments, typos or small corrections to the logic that you are sure won't overlap with what the author is doing then go ahead, otherwise its good to let the PR author know you intend to help out with certain areas of the PR.

Having said that, I am still making changes to this draft but help is very welcomed still.

coderabbitai

Actionable comments posted: 1

🤖 Fix all issues with AI agents

In `@Flow.Launcher/Storage/QueryHistory.cs`:
- Around line 80-82: The comparison accessing existingHistoryItem.Glyph.Glyph
and .FontFamily can throw when either Glyph is null; update the condition in
QueryHistory.cs to perform null-safe comparisons (e.g., compare
existingHistoryItem.Glyph and result.Glyph for null first, then compare
Glyph.Glyph and Glyph.FontFamily only when non-null) so that you assign
existingHistoryItem.Glyph = result.Glyph when either Glyph is null or any of the
two properties differ; reference the existingHistoryItem.Glyph, result.Glyph,
Glyph.Glyph and Glyph.FontFamily symbols when making the change.

🧹 Nitpick comments (1)

Flow.Launcher/Storage/QueryHistory.cs (1)
7-7: Remove unused using Svg; directive.

This namespace isn't referenced anywhere in the file.
🔧 Proposed fix
-using Svg;

Flow.Launcher/Storage/QueryHistory.cs

coderabbitai

Actionable comments posted: 1

🤖 Fix all issues with AI agents

In `@Flow.Launcher/ViewModel/MainViewModel.cs`:
- Around line 432-449: The early return based solely on
SelectedResults.SelectedItem?.Result?.PluginID blocks built-in context-menu
items without PluginID from returning to Results; adjust the guard so it only
prevents action when in query-result context: remove or change the top-level
PluginID check and instead check PluginID only inside the QueryResultsSelected()
branch (e.g., if (QueryResultsSelected() &&
string.IsNullOrEmpty(SelectedResults.SelectedItem?.Result?.PluginID)) return) so
that built-in ContextMenu items (ContextMenu, Results, PreviewSelectedItem,
UpdatePreviewAsync()) can still fall through to the else branch and restore
Results/preview navigation.

Flow.Launcher/ViewModel/MainViewModel.cs

coderabbitai

Actionable comments posted: 0

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

Flow.Launcher/Storage/QueryHistory.cs (1)

65-88: Trim by least-recent execution, not list index.

Because existing items are now updated in place (not necessarily the last entry), RemoveAt(0) can evict a recently executed item once the cap is exceeded. Consider trimming after update/add and remove the oldest by ExecutedDateTime (or move the updated item to the end).

🐛 Proposed fix (trim by oldest execution time)

-            // Maintain the max history limit
-            if (LastOpenedHistoryItems.Count > _maxHistory)
-            {
-                LastOpenedHistoryItems.RemoveAt(0);
-            }
-
             // If the last item is the same as the current result, just update the timestamp and the icon path
             if (LastOpenedHistoryItems.Count > 0 &&
                 TryGetLastOpenedHistoryResult(result, out var existingHistoryItem))
             {
                 existingHistoryItem.ExecutedDateTime = DateTime.Now;
@@
             else
             {
                 LastOpenedHistoryItems.Add(new LastOpenedHistoryResult(result));
             }
+
+            // Maintain the max history limit (remove least-recently executed item)
+            if (LastOpenedHistoryItems.Count > _maxHistory)
+            {
+                var oldest = LastOpenedHistoryItems
+                    .OrderBy(x => x.ExecutedDateTime)
+                    .First();
+                LastOpenedHistoryItems.Remove(oldest);
+            }

jjw24 · 2026-01-20T12:21:54Z

@Jack251970 should be good to go, please review.

Jack251970

~~When we upgrade Flow from old version to new one, the icons of those old results are blank.~~

The updated history.json contains null icon path, but the missing icon is not shown.

{
      "Query": "steam",
      "ExecutedDateTime": "2026-01-15T16:16:30.9760574+08:00",
      "Title": "Steam",
      "SubTitle": "",
      "ActionKeywordAssigned": null,
      "CopyText": "",
      "AutoCompleteText": null,
      "IcoPath": null,
      "IcoPathAbsolute": null,
      "BadgeIcoPath": null,
      "RoundedIcon": false,
      ...
    },

jjw24 · 2026-01-22T10:29:24Z

I can't reproduce the issue, the missing image icon shows up for me. Maybe:

Is it the theme you are using, what is it?
Can you try do the upgrade on a fresh build
Do you still have the history.json file you upgraded from? Maybe share it with me.

Jack251970 · 2026-01-22T10:42:57Z

I can't reproduce the issue, the missing image icon shows up for me. Maybe:

Is it the theme you are using, what is it?

Can you try do the upgrade on a fresh build

Do you still have the history.json file you upgraded from? Maybe share it with me.

It seems that this problem no longer appears in the latest commit. Let us forget it

This reverts commit b703bcd.

coderabbitai

Actionable comments posted: 1

🤖 Fix all issues with AI agents

In `@Flow.Launcher.Plugin/Result.cs`:
- Around line 71-72: The XML doc comment for the Result.IcoPath property uses
invalid syntax "<IcoPathAbsolute/>"; update the remark to use a proper XML doc
cref by replacing that token with <see cref="IcoPathAbsolute"/> so the
documentation generates a proper reference to the IcoPathAbsolute member.

Flow.Launcher.Plugin/Result.cs

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

Jack251970

Overall, it works well for me. And please do the final check if necessary

Flow.Launcher.Plugin/Result.cs

add result IcoPath & Glyph + handling show badge switching

7883e7a

jjw24 self-assigned this Oct 17, 2025

jjw24 added the Dev branch only An issue or fix for the Dev branch build label Oct 17, 2025

github-actions bot added this to the 2.1.0 milestone Oct 17, 2025

Jack251970 reviewed Oct 18, 2025

View reviewed changes

Flow.Launcher/ViewModel/MainViewModel.cs Outdated Show resolved Hide resolved

Jack251970 reviewed Oct 18, 2025

View reviewed changes

Flow.Launcher/Storage/QueryHistory.cs Outdated Show resolved Hide resolved

Jack251970 requested changes Oct 18, 2025

View reviewed changes

update history result icon display logic & remove badge icon logic

10d3ba2

jjw24 commented Oct 19, 2025

View reviewed changes

Flow.Launcher/Storage/QueryHistory.cs Outdated Show resolved Hide resolved

change getting last history item to get the same result if exists

26ad473

gitstream-cm bot added the 1 min review label Oct 19, 2025

jjw24 added 2 commits October 21, 2025 21:53

show distinct records when history style is last opened

92551c5

show history result sorted descending by execution time

25aa5bf

gitstream-cm bot added 5 min review and removed 1 min review labels Oct 21, 2025

jjw24 added 3 commits October 21, 2025 22:18

remove duplicate history item sort call

0f26945

wip show result icon

7958b17

update to use IcoAbsoluteLocalPath

d78d313

gitstream-cm bot added the 10 min review label Dec 26, 2025

update glyph when history result exists

9036002

coderabbitai bot reviewed Jan 20, 2026

View reviewed changes

Flow.Launcher/Storage/QueryHistory.cs Outdated Show resolved Hide resolved

jjw24 added 2 commits January 20, 2026 21:47

fix to respect max history result shown setting

5c241d7

adjusted context menu call to exit early when history result selected

4ddb164

coderabbitai bot reviewed Jan 20, 2026

View reviewed changes

Flow.Launcher/ViewModel/MainViewModel.cs Outdated Show resolved Hide resolved

add null-safe comparison for glyph

657e6ae

coderabbitai bot reviewed Jan 20, 2026

View reviewed changes

revert context menu early exit when history result

bf44637

jjw24 requested a review from Jack251970 January 20, 2026 12:22

Code cleanup

8e127d0

Jack251970 requested changes Jan 21, 2026

View reviewed changes

Jack251970 added 3 commits January 23, 2026 15:51

Try to fix combability issue

b703bcd

Revert "Try to fix combability issue"

0f0ee9f

This reverts commit b703bcd.

Ensure combability of glyph setter

935d41d

coderabbitai bot reviewed Jan 23, 2026

View reviewed changes

Flow.Launcher.Plugin/Result.cs Outdated Show resolved Hide resolved

Fix code comments

e9dcd8b

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

Jack251970 previously approved these changes Jan 23, 2026

View reviewed changes

Flow.Launcher.Plugin/Result.cs Outdated Show resolved Hide resolved

fix preview when toggle history mode via Ctrl + H

248da93

jjw24 dismissed Jack251970’s stale review via 248da93 January 26, 2026 05:58

Jack251970 approved these changes Jan 26, 2026

View reviewed changes

jjw24 removed bug Something isn't working 30 min review labels Jan 26, 2026

jjw24 changed the title ~~Last opened history mode show result icon instead~~ History results display actual result icon for Last Opened history style Jan 26, 2026

prlabeler bot added the bug Something isn't working label Jan 26, 2026

jjw24 removed the bug Something isn't working label Jan 26, 2026

jjw24 merged commit 6c8add0 into dev Jan 26, 2026
9 checks passed

jjw24 deleted the last_history_show_result_icon branch January 26, 2026 06:50

Uh oh!

History results display actual result icon for Last Opened history style #4057

History results display actual result icon for Last Opened history style #4057

Uh oh!

Conversation

jjw24 commented Oct 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jjw24 commented Oct 17, 2025

Uh oh!

jjw24 commented Oct 17, 2025

Uh oh!

01Dri commented Oct 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

01Dri commented Oct 18, 2025

Uh oh!

Jack251970 commented Oct 18, 2025

Uh oh!

Uh oh!

Uh oh!

Jack251970 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jjw24 commented Oct 18, 2025 • edited by Jack251970 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Jack251970 commented Oct 18, 2025

Uh oh!

Uh oh!

01Dri commented Oct 19, 2025

Uh oh!

Jack251970 commented Oct 20, 2025

Uh oh!

01Dri commented Oct 20, 2025

Uh oh!

jjw24 commented Oct 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

jjw24 commented Jan 20, 2026

Uh oh!

Jack251970 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jjw24 commented Jan 22, 2026

Uh oh!

Jack251970 commented Jan 22, 2026

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Jack251970 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

jjw24 commented Oct 17, 2025 •

edited

Loading

01Dri commented Oct 18, 2025 •

edited

Loading

Jack251970 left a comment •

edited

Loading

jjw24 commented Oct 18, 2025 •

edited by Jack251970

Loading

jjw24 commented Oct 20, 2025 •

edited

Loading

Jack251970 left a comment •

edited

Loading