-
-
Notifications
You must be signed in to change notification settings - Fork 548
Revert "Upgrade iNKORE.UI.WPF.Modern and refactor scroll logic" #4201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Warning Rate limit exceeded@Jack251970 has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 1 minutes and 25 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (4)
Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
🥷 Code experts: no user but you matched threshold 10 Jack251970 has most 👩💻 activity in the files. See details
Activity based on git-commit:
Knowledge based on git-blame:
Activity based on git-commit:
Knowledge based on git-blame:
Activity based on git-commit:
Knowledge based on git-blame: ✨ Comment |
|
This PR contains a TODO statement. Please check to see if they should be removed. |
|
Be a legend 🏆 by adding a before and after screenshot of the changes you made, especially if they are around UI/UX. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR reverts a previous upgrade of the iNKORE.UI.WPF.Modern library from version 0.10.2.1 back to 0.10.1 to address a NumberBox issue. The revert restores a custom scroll viewer implementation that was removed in the previous change.
Key changes:
- Downgrade iNKORE.UI.WPF.Modern package from 0.10.2.1 to 0.10.1
- Restore custom
CustomScrollViewerExcontrol implementation for scroll handling - Update XAML templates to use the custom scroll viewer instead of the library's built-in version
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 12 comments.
| File | Description |
|---|---|
| Flow.Launcher/packages.lock.json | Downgrade iNKORE.UI.WPF.Modern from 0.10.2.1 to 0.10.1 and revert Flow.Launcher.Plugin from 5.1.0 to 5.0.0 |
| Flow.Launcher/Flow.Launcher.csproj | Update package reference to iNKORE.UI.WPF.Modern version 0.10.1 |
| Flow.Launcher/Themes/Base.xaml | Replace ui:ScrollViewerEx with cc:CustomScrollViewerEx and remove animation-related properties |
| Flow.Launcher/Resources/Controls/CustomScrollViewerEx.cs | Re-add custom scroll viewer implementation with manual scroll animation and wheel handling logic |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Reverts #4118
We need to use it to fix NumberBox issue
Before:
After: