-
-
Notifications
You must be signed in to change notification settings - Fork 548
Add framework-dependent deployment packages without bundled .NET runtime #4236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
Co-authored-by: VictoriousRaptor <[email protected]>
Co-authored-by: VictoriousRaptor <[email protected]>
Co-authored-by: VictoriousRaptor <[email protected]>
Co-authored-by: VictoriousRaptor <[email protected]>
|
In the modern day and age is 150mb really worth shaving off? My main concern is this is another option a non-technical user will need to understand- why another installation file and what's the difference between this and standard. If they move the framework free version to a computer without .Net 9 it's going fail and we might end up with another request to provide an option to install .Net 9. I think a better solution is to use Velopack and let the single setup file install the missing framework, so we don't need to pack and publish this additional one- https://docs.velopack.io/packaging/bootstrapping |
Nah this PR is only a try for Copliot. Not a serious PR and currently I am not really into this feature. |
Adds framework-dependent installation packages for users with .NET 9.0 already installed, reducing download size by ~150-200MB.
Changes
Build configuration:
Net9.0-FrameworkDependent.pubxmlpublish profile withSelfContained=false, outputs toOutput/Release-FDpost_build.ps1to build both deployment modes in sequencePackage outputs:
Flow-Launcher-Setup.exe,Flow-Launcher-Portable.zipFlow-Launcher-Setup-FD.exe,Flow-Launcher-Portable-FD.zipCI/CD:
Documentation:
Technical notes
Framework-dependent packages require .NET 9.0 runtime pre-installed on target systems. Build process handles nupkg naming conflicts by appending
-FDsuffix before Squirrel releasify step.Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.