Skip to content

Fix translation issue #4256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Jack251970 wants to merge 1 commit into from
Closed

Fix translation issue #4256

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions Flow.Launcher.Core/ExternalPlugins/Environments/AbstractPluginEnvironment.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,9 +43,10 @@ internal AbstractPluginEnvironment(List<PluginMetadata> pluginMetadataList, Plug
internal IEnumerable<PluginPair> Setup()
{
// If no plugin is using the language, return empty list
if (!PluginMetadataList.Any(o => o.Language.Equals(Language, StringComparison.OrdinalIgnoreCase)))
var pluginCount = PluginMetadataList.Count(o => o.Language.Equals(Language, StringComparison.OrdinalIgnoreCase));
if (pluginCount == 0)
{
return new List<PluginPair>();
return [];
}

if (!string.IsNullOrEmpty(PluginsSettingsFilePath) && FilesFolders.FileExists(PluginsSettingsFilePath))
Expand All @@ -57,7 +58,7 @@ internal IEnumerable<PluginPair> Setup()
return SetPathForPluginPairs(PluginsSettingsFilePath, Language);
}

var noRuntimeMessage = Localize.runtimePluginInstalledChooseRuntimePrompt(Language, EnvName, Environment.NewLine);
var noRuntimeMessage = Localize.runtimePluginInstalledChooseRuntimePrompt(pluginCount, EnvName, Environment.NewLine);
if (API.ShowMsgBox(noRuntimeMessage, string.Empty, MessageBoxButton.YesNo) == MessageBoxResult.No)
{
var msg = Localize.runtimePluginChooseRuntimeExecutable(EnvName);
Expand Down Expand Up @@ -114,7 +115,7 @@ internal IEnumerable<PluginPair> Setup()
$"Not able to successfully set {EnvName} path, setting's plugin executable path variable is still an empty string.",
$"{Language}Environment");

return new List<PluginPair>();
return [];
}
}

Expand All @@ -131,7 +132,7 @@ private void EnsureLatestInstalled(string expectedPath, string currentPath, stri

internal abstract PluginPair CreatePluginPair(string filePath, PluginMetadata metadata);

private IEnumerable<PluginPair> SetPathForPluginPairs(string filePath, string languageToSet)
private List<PluginPair> SetPathForPluginPairs(string filePath, string languageToSet)
{
var pluginPairs = new List<PluginPair>();

Expand Down
Loading