Skip to content

Fix download dialog text and filename casing#80

Open
DavidGBrett wants to merge 3 commits into
masterfrom
fix-downloads-dialog
Open

Fix download dialog text and filename casing#80
DavidGBrett wants to merge 3 commits into
masterfrom
fix-downloads-dialog

Conversation

@DavidGBrett
Copy link
Copy Markdown
Contributor

@DavidGBrett DavidGBrett commented May 29, 2026

Resolves #79

  • Removes the confusing “/ Downloads via GitHub” message in the download dialog.
  • Updates the minimum supported Windows message to “Supports Windows 10+”.
  • Renames the component file from DownloadDIalog.astro to DownloadDialog.astro.
  • Updates the corresponding import path in the layout file.

@DavidGBrett DavidGBrett marked this pull request as ready for review May 29, 2026 14:22
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 29, 2026

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: ef9a0ddc-13dc-4c09-bfb6-796a88f27a0c

📥 Commits

Reviewing files that changed from the base of the PR and between 18f3d96 and b1eb9aa.

📒 Files selected for processing (2)
  • src/components/DownloadDialog.astro
  • src/layouts/Layout.astro

📝 Walkthrough

Walkthrough

This PR addresses outdated Windows compatibility messaging in the download dialog. It fixes a typo in the DownloadDialog import and updates the support message to reflect the current Windows 10+ requirement introduced in version 2.0.0.

Changes

DownloadDialog Component Updates

Layer / File(s) Summary
Fix DownloadDialog import
src/layouts/Layout.astro
The DownloadDialog component import path is corrected from a typo (DownloadDIalog.astro) to the correct spelling (DownloadDialog.astro).
Update Windows support messaging
src/components/DownloadDialog.astro
The dialog footer text is updated from "Supports Windows 7+ / Downloads via GitHub" to "Supports Windows 10+", clarifying the current minimum version requirement.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

  • Flow-Launcher/flow-launcher.github.io#51: Both PRs modify the DownloadDialog.astro component; #51 updates the winget install command while this PR fixes the layout import and updates the Windows version support text.

Suggested reviewers

  • deefrawley
  • jjw24
  • Jack251970
  • onesounds
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Linked Issues check ⚠️ Warning The PR partially addresses issue #79 by updating the Windows version text and fixing casing, but does not implement direct GitHub release links as requested. Consider adding direct links to GitHub releases and prereleases pages as suggested in issue #79 to fully resolve the feature request.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the main changes: fixing the download dialog text and the filename casing issue.
Description check ✅ Passed The description clearly outlines all changes made and directly references the resolved issue #79.
Out of Scope Changes check ✅ Passed All changes are directly related to resolving issue #79: updating the support message, fixing the filename casing, and updating the import path.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix-downloads-dialog

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

ESLint skipped: no ESLint configuration detected in root package.json. To enable, add eslint to devDependencies.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@DavidGBrett DavidGBrett self-assigned this May 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Windows compatability outdated & unclear github downloads mention

1 participant