Use port from config file

[hardillb]

fixes #312

Description

Default options overwrite port number in config file

Related Issue(s)

#312

Checklist

• I have read the contribution guidelines
• Suitable unit/system level tests have been added and they pass
• Documentation has been updated
  • Upgrade instructions
  • Configuration details
  • Concepts
• Changes flowforge.yml?
  • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
  • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

• Includes a DB migration? -> add the area:migration label

[knolleary]

I don't think this is the approach we want to take as it will mean explicitly set command-line args do not override the settings file.

The core issue is the fact that if no port option is provided on the command line, the code defaults as if 1880 had been set on the command-line - and overrides the file.

I think the order of precedence should be:

1. Command Line
2. Settings file
3. Default value

That will require a bit more to achieve than just reordering the spread operations

[hardillb]

OK,

So I think if we

• remove the default options from the default options from the cli config
• add a default options object to the start of the spread
• swap the order back to cli parse options last in the spread

e.g.

const defaults = {
  port: 1880.
  ...
}

return {
        version,
        ...defaults,
        ...parsedOptions.deviceConfig
        ...options,
    }