Skip to content

Conversation

ppawlowski
Copy link
Contributor

Description

This pull request adds support for MacOS operating system

Related Issue(s)

#384

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

  • Includes a DB migration? -> add the area:migration label

@knolleary
Copy link
Member

First time trying the installer. It appears to have worked. But I have quesitons that I suspect have been discussed at length in other reviews...

  1. [ERROR]: FlowFuse one time code is required for installation - so you can't just install the agent?
  2. No choice about setting up a service - not what I was expecting
  3. No choice on user dir - so I can't run multiple agents locally (edge case, and I know there is an issue open for this)
  4. Not sure what to do after the install completes... needs a clear 'what to do next' message like You can access the agent through the FlowFuse platform at <url> or something like that.
✔ Success
Configuration completed successfully!
Configuring FlowFuse Device Agent to run as system service...
Installing service flowfuse-device-agent for darwin
FlowFuse Device Agent installation completed successfully!
The service is now running and will start automatically on system boot.

No idea how to clean this up or check the logs or anything else I'm used to doing when running the agent manually.

@ppawlowski
Copy link
Contributor Author

  1. [ERROR]: FlowFuse one time code is required for installation - so you can't just install the agent?
  2. No choice about setting up a service - not what I was expecting

The goal on the first iteration is to simplify the device agent onboarding process. Installation of the device agent without OTC will be handled in later iteration (tracking issue).
Regarding setting up a service - what kind of choice would you have?

  1. No choice on user dir - so I can't run multiple agents locally (edge case, and I know there is an issue open for this)

Indeed, this feature will be implemented in the next version.

  1. Not sure what to do after the install completes... needs a clear 'what to do next' message like You can access the agent through the FlowFuse platform at <url> or something like that.
    No idea how to clean this up or check the logs or anything else I'm used to doing when running the agent manually.

Improved summary message here.

@ppawlowski ppawlowski requested review from knolleary and removed request for knolleary June 21, 2025 10:06
@ppawlowski
Copy link
Contributor Author

@knolleary can I get one more look, please?

@knolleary
Copy link
Member

My suggestion was to include a link back to the platform - as we have the url available to us via the -u flag - rather than the docs. Is that possible?

Base automatically changed from feat-device-win-installer to main June 25, 2025 16:27
@ppawlowski ppawlowski changed the title feat: Add support for MacOS to the Device Agent Installer feat(installer): Add support for MacOS to the Device Agent Installer Jun 25, 2025
@ppawlowski ppawlowski merged commit 561c3ac into main Jun 25, 2025
4 checks passed
@ppawlowski ppawlowski deleted the feat-device-macos-installer branch June 25, 2025 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants