feat(installer): Add possibility to install in custom directory

[ppawlowski]

Description

This pull request adds possibility to instal the device agent in a custom directory via the device agent installer.

Related Issue(s)

Closes #404
Dependent upon #446 shipping first

Checklist

• I have read the contribution guidelines
• Suitable unit/system level tests have been added and they pass
• Documentation has been updated
  • Upgrade instructions
  • Configuration details
  • Concepts
• Changes flowforge.yml?
  • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
  • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

• Includes a DB migration? -> add the area:migration label

[Steve-Mcl]

first run works great - installed to my specified dir however uninstalling did not work:

Install

flowfuse-device-installer-windows-amd64.exe -d c:\da1
One time code has not been provided. The Device Agent automatic configuration is not possible.
Do you want to continue with the installation? (y/N): y  
--<snip-for-brevity>--
FlowFuse Device Agent installation completed successfully!
The Device Agent has been installed but it is not configured.
To complete the setup:
 1. Create a device.yml configuration file in c:\da1 directory
 2. Start the Device Agent service
For information on how to manage the FlowFuse Device Agent,
  please refer to the documentation at https://github.com/FlowFuse/device-agent/blob/main/installer/README.md

uninstall attempt #1

flowfuse-device-installer-windows-amd64.exe --uninstall
****************************************************************
*            FlowFuse Device Agent Installer                   *
*                                                              *
* This installer will set up the FlowFuse Device Agent on your *
* system and configure it to run as a system service.          *
*                                                              *
****************************************************************
[ERROR] Uninstall validation failed: c:\opt\flowfuse-device is not the FlowFuse Device Agent directory. If you installed it in a custom directory, please specify it using `--dir` flag

So I understand why this occurred but it adds credence to my prior suggestions of copying the installer local and adding uninstaller batch scripts that the user can discover/run AND the windows registry can use for a windows familiar admin.

uninstall attempt #2

flowfuse-device-installer-windows-amd64.exe -d c:\da1 --uninstall
****************************************************************
*            FlowFuse Device Agent Installer                   *
*                                                              *
* This installer will set up the FlowFuse Device Agent on your *
* system and configure it to run as a system service.          *
*                                                              *
****************************************************************
[ERROR] Uninstall validation failed: c:\da1 is not the FlowFuse Device Agent directory. If you installed it in a custom directory, please specify it using `--dir` flag

uninstall attempt #3

flowfuse-device-installer-windows-amd64.exe --uninstall  -d c:\da1
****************************************************************
*            FlowFuse Device Agent Installer                   *
*                                                              *
* This installer will set up the FlowFuse Device Agent on your *
* system and configure it to run as a system service.          *
*                                                              *
****************************************************************
[ERROR] Uninstall validation failed: c:\da1 is not the FlowFuse Device Agent directory. If you installed it in a custom directory, please specify it using `--dir` flag

uninstall attempt #4

flowfuse-device-installer-windows-amd64.exe --dir c:\da1 --uninstall
****************************************************************
*            FlowFuse Device Agent Installer                   *
*                                                              *
* This installer will set up the FlowFuse Device Agent on your *
* system and configure it to run as a system service.          *
*                                                              *
****************************************************************
[ERROR] Uninstall validation failed: c:\da1 is not the FlowFuse Device Agent directory. If you installed it in a custom directory, please specify it using `--dir` flag

uninstall attempt #5

flowfuse-device-installer-windows-amd64.exe --uninstall --dir c:\da1
****************************************************************
*            FlowFuse Device Agent Installer                   *
*                                                              *
* This installer will set up the FlowFuse Device Agent on your *
* system and configure it to run as a system service.          *
*                                                              *
****************************************************************
[ERROR] Uninstall validation failed: c:\da1 is not the FlowFuse Device Agent directory. If you installed it in a custom directory, please specify it using `--dir` flag

Content of HDD

[ppawlowski]

@Steve-Mcl Directory validation function improved.

[Steve-Mcl]

windows local testing all good.

[hardillb]

Testing both install directory and no otc on Linux.

I get the following prompt:

You can either:
  1. Install the device agent only (you'll need to configure it manually later)
  2. Provide a device configuration file now
Do you want to provide a device agent configuration now? (Y/n)

This appears to be presenting a 1 or 2 but then asks a yes / no question about option 1. I feel it would be more natural to ask for path 1 or 2

[hardillb]

Also not 100% related, but if you choose to use an existing user (the current user) when uninstalling it tries to remove that user without asking.

[hardillb]

Approved with comments in main body of PR.

Happy to ship but needs follow up PR about user removal and possibly the setup question.

[joepavitt]

@ppawlowski can I get a status update here please?

[ppawlowski]

@ppawlowski can I get a status update here please?

It's pending a review after a recent bug discovery in the Windows installation.

[Steve-Mcl]

From My POV @joepavitt, this item was called out on my standup. I was mid testing it when another commit (Fix nssm appParameter) landed. I have just pulled it and will be doing re-review momentarily. Hold tight :)

[Steve-Mcl]

tested install/uninstall with/without OTC, with/without -d, --dir (spaces and no spaces in dir name)

All good.