refactor(installer): Improve installation summary message #495
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hardillb
approved these changes
Sep 10, 2025
Steve-Mcl
approved these changes
Sep 11, 2025
|
|
||
| logger.Info("") | ||
| logger.Info("For more details on managing the FlowFuse Device Agent, including commands for starting, stopping, and updating the service, visit:") | ||
| logger.Info("https://flowfuse.com/docs/device-agent/install/overview") |
There was a problem hiding this comment.
I assume this page will exist before release?
installer/go/pkg/utils/utils.go
Outdated
| logger.Info(" 1. Create a device.yml configuration file in the %s directory", workDir) | ||
| logger.Info(" 2. Start the Device Agent service") | ||
| logger.Info("Refer to the documentation for detailed configuration steps and examples.") | ||
| logger.Info("Once configured, you can return to the FlowFuse platform (%s) and start creating Node-RED flows on your device.", url) |
There was a problem hiding this comment.
Is it worth considering separating the URL from the middle of the text to its own line?
installer/go/pkg/utils/utils.go
Outdated
| logger.Info("Once configured, you can return to the FlowFuse platform (%s) and start creating Node-RED flows on your device.", url) | ||
| case "none": | ||
| logger.Info("The FlowFuse Device Agent was already configured. The service is running and ready to use.") | ||
| logger.Info("You can return to the FlowFuse platform (%s) and start creating Node-RED flows on your device.", url) |
There was a problem hiding this comment.
Is it worth considering separating the URL from the middle of the text to its own line?
installer/go/pkg/utils/utils.go
Outdated
| switch installMode { | ||
| case "otc", "manual": | ||
| logger.Info("The FlowFuse Device Agent is now running and will start automatically on system boot.") | ||
| logger.Info("You can return to the FlowFuse platform (%s) and start creating Node-RED flows on your device.", url) |
There was a problem hiding this comment.
Is it worth considering separating the URL from the middle of the text to its own line?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request impreves the installation message summary to include valid FlowFuse platform and documentation links.
Additionally, to maintain clean approach, dedicated function has been introduced for this purpose.
Related Issue(s)
Closes #427
Checklist
flowforge.yml?FlowFuse/helmto update ConfigMap TemplateFlowFuse/CloudProjectto update values for Staging/ProductionLabels
area:migrationlabel