Skip to content

Conversation

hardillb
Copy link
Contributor

Description

Ensure that HA logs get combined properly now we have paging enabled.

Related Issue(s)

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

  • Includes a DB migration? -> add the area:migration label

@hardillb hardillb requested a review from knolleary May 13, 2025 14:42
@hardillb hardillb self-assigned this May 13, 2025
@knolleary
Copy link
Member

The /flowforge/logs endpoint in the launcher still returns the plain array.

The PR I did adds a new endpoint /flowforge/logs/entries which does the proper pagination. But that's as far as that work got; still need to do the work to plumb that through the drivers. So as it stands, I don't think this PR is needed (yet).

@hardillb
Copy link
Contributor Author

OK, I'll flip it back to draft for now and we can tweak it for the new endpoint when needed.

@hardillb hardillb marked this pull request as draft May 13, 2025 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants