Skip to content

feat: Improve projects ingress annotations logic #242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

feat: Improve projects ingress annotations logic #242

wants to merge 3 commits into from
+82 −1

Conversation

ppawlowski
Copy link
Contributor

@ppawlowski ppawlowski commented Oct 6, 2025 •
edited
Loading

Description

This pull request improves the logic for projects' ingress annotations.

  1. For backward compatibility, the cert-manager.io/cluster-issuer annotation is added with the value defined in this._certManagerIssuer. Other, not related to the cert-manager, annotations are added as well. The tls configuration block is added.
  2. If this._certManagerIssuer is not specified, all annotations defined in the this._projectIngressAnnotations. If any of the annotations start with cert-managet.io/, the required tls configuration block is added too.

The same logic is applied to the customHostname ingresses.

Related Issue(s)

FlowFuse/helm#683

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production
  • Link to Changelog Entry PR, or note why one is not needed.

Labels

  • Includes a DB migration? -> add the area:migration label

@ppawlowski ppawlowski requested a review from hardillb October 6, 2025 12:45
@ppawlowski ppawlowski mentioned this pull request Oct 6, 2025
Open
11 tasks
@ppawlowski ppawlowski marked this pull request as draft October 6, 2025 16:49
hardillb
hardillb reviewed Oct 6, 2025
View reviewed changes
@ppawlowski ppawlowski marked this pull request as ready for review October 6, 2025 17:03
@ppawlowski ppawlowski requested a review from hardillb October 6, 2025 17:03
hardillb
hardillb approved these changes Oct 7, 2025
View reviewed changes
Copy link
Contributor

@hardillb hardillb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've done some basic testing on my home rig and looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hardillb hardillb hardillb approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ppawlowski @hardillb