-
Notifications
You must be signed in to change notification settings - Fork 74
Expose SAML SSO groups to Dashboard #6041
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #6041 +/- ##
==========================================
- Coverage 76.75% 76.69% -0.07%
==========================================
Files 378 379 +1
Lines 18967 18993 +26
Branches 4516 4522 +6
==========================================
+ Hits 14559 14567 +8
- Misses 4408 4426 +18
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple additional changes needed:
- The 'provision new user on login' route needs updating to capture the group info (the else case around line 109 in
forge/ee/routes/sso/auth.js
- The
groupAssertionName
property is only visible if the 'manage group membership' option is enabled. The value gets reset to blank if that option is toggled off. So as it stands, no way to enable this feature without also enabling manage group membership. Suggest the quick fix is to move the new option under the manage group membership option for now. We can move it out as an independent option if the need arises in the future,
move sso settings toggle to under groups setttings Ensure new users are populated when created via SSO
fixes #5902
Description
If enabled in the SSO provider settings this adds the list of groups to the FlowFuse User object on each SSO login.
This can then be retrieved by the nr-launcher middleware when using FF Authentication and exposed to the Dashboard
depends on FlowFuse/nr-launcher#389
DO NOT MERGE BEFORE #6003 as it contains db migrationRelated Issue(s)
#5902
Checklist
flowforge.yml
?FlowFuse/helm
to update ConfigMap TemplateFlowFuse/CloudProject
to update values for Staging/ProductionLabels
area:migration
label