Skip to content

Conversation

mxr2004
Copy link

@mxr2004 mxr2004 commented Sep 24, 2025

Description

regarding #14 . Added the possiblity to set custom time and sender.

Related Issue(s)

Closes #14

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production
  • Link to Changelog Entry PR, or note why one is not needed.

Labels

  • [-] Includes a DB migration? -> add the area:migration label

Copy link
Contributor

@joepavitt joepavitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @mxr2004 - thanks for the PR. The files changed are a little odd.

Why remove the image from the README, and only submit changes to the umd.js? I'm seeing no changes in the source code here

@mxr2004 mxr2004 requested a review from joepavitt September 25, 2025 07:41
@mxr2004
Copy link
Author

mxr2004 commented Sep 25, 2025

Hey @joepavitt, sorry for the confusion. I commited the correct changes now and re-requested your review! If there are still any problems let me know :)

Copy link
Contributor

@joepavitt joepavitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only other feedback I have hereOverall, works great, one comment re: code, and my only other request would be, please add a "Load Message History" sub-section into the readme under the Using in a Flow section so that users know how to make the most of this new feature set

@mxr2004 mxr2004 requested a review from joepavitt September 30, 2025 15:41
@mxr2004
Copy link
Author

mxr2004 commented Sep 30, 2025

All done 😄 @joepavitt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

FR: Add support for custom set time and sender attribute

3 participants