Skip to content

Conversation

colinl
Copy link
Contributor

@colinl colinl commented Oct 3, 2025

Description

Version 1.28.0 has the font size for the label (title in eCharts) set to 14. This gives a font size larger than in the previous chartjs version, leading to problems such as that in #1885 where the label is too long to fit the space. This PR reduces the font to 12.5 which appears to that which was used by chartjs.

Related Issue(s)

Partially fixes #1885

Checklist

  • [x ] I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production
  • Link to Changelog Entry PR, or note why one is not needed.

Labels

  • Includes a DB migration? -> add the area:migration label

@Steve-Mcl
Copy link
Contributor

Hi @colinl thanks very much for this. Greatly appreciated.

Where did you find that chartjs had a default 12.5 font?

@colinl
Copy link
Contributor Author

colinl commented Oct 3, 2025

By installing the previous version of the dashboard and measuring the length of a string in the title on screen, then experimented to find the font that gave the same size now. I don't know whether that is the default size in chartjs, but it appears to be the size that the dashboard used in the chart node.

@colinl
Copy link
Contributor Author

colinl commented Oct 3, 2025

I notice there is no font size spec for the radial chart. Should there be to keep the two types looking the same?

@Steve-Mcl
Copy link
Contributor

By installing the previous version of the dashboard and measuring the length of a string in the title on screen, then experimented to find the font that gave the same size now.

Thanks for that. That is a reasonable enough justification for me.

@Steve-Mcl Steve-Mcl self-requested a review October 3, 2025 13:03
Copy link
Contributor

@Steve-Mcl Steve-Mcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved while acknowledging this is a band aid to the real problem - but every little helps.

Thanks Colin.

@Steve-Mcl Steve-Mcl merged commit e578b20 into FlowFuse:main Oct 3, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

New version of the diagrams all curved and oblique!!

2 participants