Skip to content

fix: add Redis connection resilience settings to prevent infinite hangs #5219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: add Redis connection resilience settings to prevent infinite hangs #5219

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bede455
fix: add Redis connection resilience settings to prevent infinite hangs
utsav-bx Sep 15, 2025
7d58067
Merge branch 'main' into bugfix/redis-connection-timeout-fix
utsav-bx Sep 20, 2025
2c21fc4
removed packageManager pinning from package.json
utsav-bx Sep 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,5 +127,6 @@
}
]
]
}
},
"packageManager": "[email protected]+sha512.486ebc259d3e999a4e8691ce03b5cac4a71cbeca39372a9b762cb500cfdf0873e2cb16abe3d951b1ee2cf012503f027b98b6584e4df22524e0c7450d9ec7aa7b"
}
8 changes: 8 additions & 0 deletions packages/server/.env.example
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,6 +163,14 @@ JWT_REFRESH_TOKEN_EXPIRY_IN_MINUTES=43200
# REDIS_KEY=
# REDIS_CA=
# REDIS_KEEP_ALIVE=

# Redis Connection Resilience Settings (fixes infinite hangs on connection drops)
# REDIS_CONNECT_TIMEOUT=10000 # Connection timeout in milliseconds
# REDIS_COMMAND_TIMEOUT=30000 # Command timeout in milliseconds (prevents waitUntilFinished hanging)
# REDIS_MAX_RETRIES_PER_REQUEST=3 # Maximum retries per Redis command
# REDIS_LAZY_CONNECT=true # Connect only when needed
# REDIS_KEEPALIVE_INTERVAL=30000 # Keep-alive interval in milliseconds

# ENABLE_BULLMQ_DASHBOARD=


Expand Down
21 changes: 19 additions & 2 deletions packages/server/src/queue/QueueManager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,13 @@ import { ExpressAdapter } from '@bull-board/express'

const QUEUE_NAME = process.env.QUEUE_NAME || 'flowise-queue'

// Redis resilience configuration with environment variable support
const REDIS_CONNECT_TIMEOUT = process.env.REDIS_CONNECT_TIMEOUT ? parseInt(process.env.REDIS_CONNECT_TIMEOUT, 10) : 10000
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer not to hardcode a default value for these.

If these are set, we only pass it in, if not, we leave it

const REDIS_COMMAND_TIMEOUT = process.env.REDIS_COMMAND_TIMEOUT ? parseInt(process.env.REDIS_COMMAND_TIMEOUT, 10) : 30000
const REDIS_MAX_RETRIES_PER_REQUEST = process.env.REDIS_MAX_RETRIES_PER_REQUEST ? parseInt(process.env.REDIS_MAX_RETRIES_PER_REQUEST, 10) : 3
const REDIS_LAZY_CONNECT = process.env.REDIS_LAZY_CONNECT === 'false' ? false : true
const REDIS_KEEPALIVE_INTERVAL = process.env.REDIS_KEEPALIVE_INTERVAL ? parseInt(process.env.REDIS_KEEPALIVE_INTERVAL, 10) : 30000

type QUEUE_TYPE = 'prediction' | 'upsert'

export class QueueManager {
Expand Down Expand Up @@ -45,7 +52,12 @@ export class QueueManager {
keepAlive:
process.env.REDIS_KEEP_ALIVE && !isNaN(parseInt(process.env.REDIS_KEEP_ALIVE, 10))
? parseInt(process.env.REDIS_KEEP_ALIVE, 10)
: undefined
: REDIS_KEEPALIVE_INTERVAL,
// Enhanced resilience settings
connectTimeout: REDIS_CONNECT_TIMEOUT,
commandTimeout: REDIS_COMMAND_TIMEOUT,
maxRetriesPerRequest: REDIS_MAX_RETRIES_PER_REQUEST,
lazyConnect: REDIS_LAZY_CONNECT
}
} else {
let tlsOpts = undefined
Expand All @@ -66,7 +78,12 @@ export class QueueManager {
keepAlive:
process.env.REDIS_KEEP_ALIVE && !isNaN(parseInt(process.env.REDIS_KEEP_ALIVE, 10))
? parseInt(process.env.REDIS_KEEP_ALIVE, 10)
: undefined
: REDIS_KEEPALIVE_INTERVAL,
// Enhanced resilience settings
connectTimeout: REDIS_CONNECT_TIMEOUT,
commandTimeout: REDIS_COMMAND_TIMEOUT,
maxRetriesPerRequest: REDIS_MAX_RETRIES_PER_REQUEST,
lazyConnect: REDIS_LAZY_CONNECT
}
}
}
Expand Down