Change the log level of stub functions#1795
Merged
Merged
Conversation
Member
|
That depends on how you interpret a "STUB". I could argue, that those STUBs are to be implemented downstream, rather than being used as is, which would be an error. Error, because fluidsynth is trying to use functionality, which your OSAL doesn't provide. Compromise: conditional log level depending on whether it's a debug or release build. I.e. if |
Member
|
Oh, and pls. rebase your changes against |
Contributor
Author
|
Alright. That seems fair. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We're having problems at mkxp-z/mkxp-z#321 with the "function is a stub" log messages sometimes emitted by FluidSynth when configured with
-Dosal=cpp11or-Dosal=embeddedbeing annoying to end users. Given that they don't indicate an error that occurred within FluidSynth, maybe they shouldn't be error messages?