fix duel::clear, add interpreter::unregister_card#826
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adjusts duel::clear() to properly detach Lua-exposed objects before freeing them, preventing Lua from retaining stale references across duel reload/reset operations.
Changes:
- Unregister
groupobjects from the Lua registry before deleting them duringduel::clear(). - Unregister
effectobjects from the Lua registry before deleting them duringduel::clear().
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
mercury233
changed the title
duel::clearduel::clear, add interpreter::unregister_card
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
duel::clearis currently only called inDebug.ReloadFieldBegin. At that case, there should be only 1 card in the cards set, which istemp_card, and nothing in groups or effects. This fix prevent the leak of the temp card.