fix & update Debug.PreAddCounter#827
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes Debug.PreAddCounter’s Lua argument handling so it no longer implicitly depends on a 3rd stack argument being present, and simplifies counter type handling to match the underlying card::counter_map key type.
Changes:
- Default the optional 3rd parameter (
count) to1and only read it when provided. - Simplify counter type handling by using
uint16_tdirectly (matchingcard::counter_map).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It was requiring 2 params in
check_param_count, but actually require 3. Now it use 1 as the default value of the 3rd paramcount.And the truncation logic was redundant.