Skip to content

feat: Add client hints for cards with "sent to GY this turn" effects#3020

Open
vuryleo wants to merge 13 commits into
Fluorohydride:masterfrom
vuryleo:feat-grave-this-turn
Open

feat: Add client hints for cards with "sent to GY this turn" effects#3020
vuryleo wants to merge 13 commits into
Fluorohydride:masterfrom
vuryleo:feat-grave-this-turn

Conversation

@vuryleo

@vuryleo vuryleo commented Sep 7, 2025

Copy link
Copy Markdown
Contributor

This change introduces client hint support for cards whose effects are only enabled if they were sent to the GY during the current turn.

Details

  • Added hints to improve clarity when activating effects that depend on the card being sent to the GY this turn.

  • Ensures the client can better display activation possibilities and reduce ambiguity for the player.

  • Helps with smoother UI/UX when handling GY-triggered effects.

Impact

  • No change to core mechanics or rulings.

  • Only improves client feedback and usability.

for full card list, ref to

https://docs.qq.com/sheet/DWndsYXFjc3pkZmtM?tab=2mbp5b

image

add string:

!system 227 符合墓地效果发动条件
!system 227 GY effect available

ATTENTION

Adjusted 2 cards logic to fit the requirement:

  • 63009228 レスキュー・インターレーサー
  • 71861848 転生炎獣コヨーテ

Now the flag will only be set if the monster is in GY. Previously the flag will be registered if the monster is banished as well.

@purerosefallen

purerosefallen commented Sep 8, 2025

Copy link
Copy Markdown
Collaborator

Does it require a database string update?
Plus, if the same string used too many times, consider add an entry in strings.conf. You may open a PR in http://github.com/Fluorohydride/ygopro

@yybbwc

yybbwc commented Sep 8, 2025

Copy link
Copy Markdown

关于s的更改太多了,以至于不好看核心更改。之前有一个更改提示的pr也是这样。

@vuryleo

vuryleo commented Sep 8, 2025

Copy link
Copy Markdown
Contributor Author

yes it need a cdb update. the most common one "send to GY this turn" is used for 21 times. Whether this worth a string?

@vuryleo

vuryleo commented Sep 8, 2025

Copy link
Copy Markdown
Contributor Author

关于s的更改太多了,以至于不好看核心更改。之前有一个更改提示的pr也是这样。

you can compare with diff base.

@yybbwc

yybbwc commented Sep 8, 2025

Copy link
Copy Markdown

顺便问个懒人想法,为啥不采用更简单统一的提示呢?(例如“这张卡满足自身效果条件”)

@vuryleo

vuryleo commented Sep 8, 2025

Copy link
Copy Markdown
Contributor Author

顺便问个懒人想法,为啥不采用更简单统一的提示呢?(例如“这张卡满足自身效果条件”)

not bad, what do you think? @purerosefallen

@purerosefallen

Copy link
Copy Markdown
Collaborator

顺便问个懒人想法,为啥不采用更简单统一的提示呢?(例如“这张卡满足自身效果条件”)

not bad, what do you think? @purerosefallen

ask @pokeboyexn about opinions on product design

@purerosefallen

Copy link
Copy Markdown
Collaborator

you may provide the added string entry and cdb UPDATE statement in the comment here.

@vuryleo

vuryleo commented Sep 9, 2025

Copy link
Copy Markdown
Contributor Author
image

the hint message would be "符合墓地效果发动条件".

@purerosefallen

purerosefallen commented Sep 9, 2025

Copy link
Copy Markdown
Collaborator

the hint message would be "符合墓地效果发动条件".

Then add it as 227 in strings.conf, as 2XX entries are for in-game texts, and 226 occupied in #3021

and plz add it in the PR description as how the above PR did

@vuryleo

vuryleo commented Sep 9, 2025

Copy link
Copy Markdown
Contributor Author

i may need wait until next core release on it.

@vuryleo

vuryleo commented Sep 9, 2025

Copy link
Copy Markdown
Contributor Author

added 40 more cards, and adjusted 2 cards logic to fit the requirement:

  • 63009228 レスキュー・インターレーサー
  • 71861848 転生炎獣コヨーテ

Now the flag will only be set if the monster is in GY. Previously the flag will be registered if the monster is banished as well.

@purerosefallen

Copy link
Copy Markdown
Collaborator

Please try to do minimal changes to script and keep script format untouched.

Now maintainers would not only review things about EFFECT_FLAG_CLIENT_HINT but also if the scripts work as usual, taking more time to proceed.

@mercury233 mercury233 added this to the 0x1363 milestone Jan 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants