Fix destroy replacement filters: enforce IsImmuneToEffect and snapshot destroy group#3126
Open
vuryleo wants to merge 3 commits into
Open
Fix destroy replacement filters: enforce IsImmuneToEffect and snapshot destroy group#3126vuryleo wants to merge 3 commits into
vuryleo wants to merge 3 commits into
Conversation
This reverts commit d2f5e2c.
Contributor
Author
|
i only manually tested 六花聖カンザシ, エヴォルド・フォリス and 魔界特派員デスキャスター |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the destroy-replacement implementation for 六花聖カンザシ, エヴォルド・フォリス and 魔界特派員デスキャスター etc to correctly handle destruction group snapshotting and release validation during EFFECT_DESTROY_REPLACE.
This PR updates ~30 card scripts that use EFFECT_DESTROY_REPLACE to ensure the replacement target is always legal, with particular focus on enforcing effect immunity checks (not c:IsImmuneToEffect(e)) when selecting the replace candidate.
Testing notes
Confirmed replacement cannot select: