Refactor subgroup checks and simplify ritual additional hooks#3161
Open
vuryleo wants to merge 16 commits into
Open
Refactor subgroup checks and simplify ritual additional hooks#3161vuryleo wants to merge 16 commits into
vuryleo wants to merge 16 commits into
Conversation
Collaborator
|
I don't suggest introducing breaking changes to GCheckAdditional |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
API changes
GCheckAdditionalnow receives only the current subgroup; utility-side subgroup checks no longer pass the selected card or branch poolRGCheckAdditionalnow receives only the current ritual material subgroup; ritual-side additional checks no longer pass a singled-out material*_checkplus*_check_specpairs (for exampledncheck/dncheck_spec), and the older exported*_additional/*_classifierhelpers are removed from the utility surfaceclassifier(c)values and are precomputed once per subgroup contextGroup, e.g.g:WithSubGroupContext(additional, classifier):CheckSubGroup(...)andg:WithCheckSpec(spec):SelectSubGroup(...)Notes