Skip to content

move to C++17 #2718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
salix5 wants to merge 2 commits into from
Closed

move to C++17 #2718

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fc4151b
C++17 features
salix5 Mar 8, 2025
4344ae2
update premake5.lua
salix5 Mar 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions gframe/irrUString.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -449,7 +449,7 @@ class ustring16 {
//! Returns the length of a ustring16 in full characters.
//! \return Length of a ustring16 in full characters.
u32 size() const {
if (sizeof(wchar_t) == 4) {
if constexpr (sizeof(wchar_t) == 4) {
return size_raw_;
} else {
if(size_ != 0xffffffff)
Expand Down Expand Up @@ -524,7 +524,7 @@ class ustring16 {
//! \return A reference to our current string.
void validate() {
// Validate all unicode characters.
if (sizeof(wchar_t) == 4) {
if constexpr (sizeof(wchar_t) == 4) {
size_ = size_raw_;
return;
}
Expand Down
2 changes: 1 addition & 1 deletion gframe/network.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
#include <event2/thread.h>
#include <type_traits>

#define check_trivially_copyable(T) static_assert(std::is_trivially_copyable<T>::value == true && std::is_standard_layout<T>::value == true, "not trivially copyable")
#define check_trivially_copyable(T) static_assert(std::is_trivially_copyable_v<T> == true && std::is_standard_layout_v<T> == true, "not trivially copyable")

namespace ygo {
constexpr int SIZE_NETWORK_BUFFER = 0x20000;
Expand Down
2 changes: 1 addition & 1 deletion gframe/premake5.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ include "spmemvfs/."

project "YGOPro"
kind "WindowedApp"
cppdialect "C++14"
cppdialect "C++17"
rtti "Off"
openmp "On"

Expand Down