update windows build matrix#2781
Merged
Merged
Conversation
add x64, support no dxsdk
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the Windows build matrix to add x64 support and enable a build configuration without the DirectX SDK. Key changes include:
- Introducing a new option ("no-dxsdk") to disable DirectX SDK usage.
- Updating premake5.lua to conditionally set USE_DXSDK based on the new option.
- Expanding the GitHub workflow build matrix with variants for x64, XP, irrKlang, and no-dxsdk builds.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| premake5.lua | Adds new option for no-dxsdk and updates build filters for Win32/x64. |
| premake/irrlicht/premake5.lua | Adjusts include paths based on USE_DXSDK status for Direct3D 9 configuration. |
| .github/workflows/build.yml | Updates the build matrix and related steps to support new Windows variants. |
Comments suppressed due to low confidence (1)
.github/workflows/build.yml:244
- Verify that the expression for selecting the Platform ('x64' vs 'Win32') works as intended across all configurations; consider using a dedicated matrix variable for platform to improve readability and robustness.
MSBuild.exe build\YGOPro.sln /m /p:Configuration=Release /p:Platform=${{ matrix.x64 && 'x64' || 'Win32' }}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add x64, support no dxsdk