use libevent 2.1.12 on windows#2806
Merged
mercury233 merged 9 commits intoJun 16, 2025
Merged
Conversation
Collaborator
|
Can it not be a draft? |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the build configuration to use libevent 2.1.12 on Windows, adds version detection/warnings in the Premake script, links the new iphlpapi library in the gframe project, and updates the GitHub Actions workflow to download and extract the 2.1.12 release.
- Introduce
EVENT_VERSIONparsing and warnings for unsupported versions or Windows XP. - Conditionally include
evutil_time.cand adjust Windows prebuild commands/defines for libevent 2.1. - Update gframe’s Premake to link
iphlpapiand change CI workflow to pull libevent 2.1.12.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| premake/event/premake5.lua | Add version parsing, warnings, conditional file inclusion, and Windows-specific defines/prebuild commands |
| gframe/premake5.lua | Link iphlpapi alongside ws2_32 |
| .github/workflows/build.yml | Point to libevent 2.1.12 release tarball and adjust extraction path |
Comments suppressed due to low confidence (1)
premake/event/premake5.lua:32
- The path segment
\\nmakemay be misinterpreted or produce an incorrect directory name. Also, this single command copies two different source folders into one target. Split into two clear commands and verify the folder name is correct (e.g.,..\\event\\WIN32-Code\\nmake).
prebuildcommands { "xcopy /E /Y $(ProjectDir)..\\event\\WIN32-Code\\nmake $(ProjectDir)..\\event\\include" }
purerosefallen
approved these changes
Jun 3, 2025
Collaborator
|
anything left? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since version 2.1.12 uses
if_nametoindex, which is a function available starting from Windows Vista, it cannot support Windows XP.