Skip to content

use libevent 2.1.12 on windows#2806

Merged
mercury233 merged 9 commits into
Fluorohydride:masterfrom
mercury233:patch-event-2.1.12-win
Jun 16, 2025
Merged

use libevent 2.1.12 on windows#2806
mercury233 merged 9 commits into
Fluorohydride:masterfrom
mercury233:patch-event-2.1.12-win

Conversation

@mercury233

@mercury233 mercury233 commented May 22, 2025

Copy link
Copy Markdown
Collaborator

Since version 2.1.12 uses if_nametoindex, which is a function available starting from Windows Vista, it cannot support Windows XP.

@purerosefallen

Copy link
Copy Markdown
Collaborator

Can it not be a draft?
I wish the whole build system using one version of libevent.

@mercury233 mercury233 marked this pull request as ready for review May 31, 2025 22:42

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the build configuration to use libevent 2.1.12 on Windows, adds version detection/warnings in the Premake script, links the new iphlpapi library in the gframe project, and updates the GitHub Actions workflow to download and extract the 2.1.12 release.

  • Introduce EVENT_VERSION parsing and warnings for unsupported versions or Windows XP.
  • Conditionally include evutil_time.c and adjust Windows prebuild commands/defines for libevent 2.1.
  • Update gframe’s Premake to link iphlpapi and change CI workflow to pull libevent 2.1.12.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File Description
premake/event/premake5.lua Add version parsing, warnings, conditional file inclusion, and Windows-specific defines/prebuild commands
gframe/premake5.lua Link iphlpapi alongside ws2_32
.github/workflows/build.yml Point to libevent 2.1.12 release tarball and adjust extraction path
Comments suppressed due to low confidence (1)

premake/event/premake5.lua:32

  • The path segment \\nmake may be misinterpreted or produce an incorrect directory name. Also, this single command copies two different source folders into one target. Split into two clear commands and verify the folder name is correct (e.g., ..\\event\\WIN32-Code\\nmake).
prebuildcommands { "xcopy /E /Y $(ProjectDir)..\\event\\WIN32-Code\\nmake $(ProjectDir)..\\event\\include" }

Comment thread premake/event/premake5.lua
Comment thread premake/event/premake5.lua Outdated
Comment thread gframe/premake5.lua
@purerosefallen

Copy link
Copy Markdown
Collaborator

anything left?

@mercury233 mercury233 merged commit 97af9bb into Fluorohydride:master Jun 16, 2025
8 checks passed
@mercury233 mercury233 deleted the patch-event-2.1.12-win branch June 16, 2025 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants