always open conformance mode#2814
Closed
salix5 wants to merge 1 commit into
Closed
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request removes the conditional check for WINXP_SUPPORT, ensuring that the conformance mode is always enabled for Visual Studio builds as per the PR title "always open conformance mode".
- Removed conditional branch checking WINXP_SUPPORT
- Forced conformance mode to "On" unconditionally
Comments suppressed due to low confidence (1)
premake5.lua:339
- The removal of the WINXP_SUPPORT condition forces 'conformancemode' to always be enabled. If WINXP_SUPPORT is no longer used elsewhere, consider cleaning up its references to improve code clarity.
if not WINXP_SUPPORT then
Collaborator
|
do toolset v141_xp support this? |
Collaborator
Author
|
I am not sure. |
Collaborator
|
https://ci.appveyor.com/project/mercury233/ygopro/builds/52156187 It does not. Since we have already checked conformance on other versions of the toolset, this check can be exempted in order to maintain support for XP. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://learn.microsoft.com/en-us/cpp/build/reference/permissive-standards-conformance?view=msvc-170