add CTOS_EXTERNAL_ADDRESS#2832
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new message type, CTOS_EXTERNAL_ADDRESS, for routing YGOPro traffic through reverse proxies. Key changes include adding CTOS_EXTERNAL_ADDRESS definitions in network headers, a new case in netserver packet handling, and client logic for sending the external address data.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| gframe/network.h | Added CTOS_EXTERNAL_ADDRESS structure documentation and LEN_HOSTNAME constant. |
| gframe/netserver.cpp | Added a case for CTOS_EXTERNAL_ADDRESS with placeholder (commented) implementation. |
| gframe/duelclient.cpp | Implemented sending of CTOS_EXTERNAL_ADDRESS data using manual buffer construction. |
mercury233
reviewed
Jun 18, 2025
… patch-add-hostname
Collaborator
Author
mercury233
reviewed
Jun 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Identical to the
HostandX-Forwarded-Forheader in HTTP.Not used in YGOPro itself, but useful in some reverse proxy or something like
nginxorbungeecordto route YGOPro traffic.