use std::strncpy#2834
Closed
salix5 wants to merge 2 commits into
Closed
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR replaces unsafe strcpy/strncat calls with bounds-checked std::strncpy and updates snprintf to use sizeof for safer buffer handling.
- Replace
strcpywithstd::strncpyand manual null-termination inSoundManager::PlaySoundEffect. - Update
snprintfto usesizeof soundPathinstead of hardcoded length. - Replace
strncatpattern withstd::strncpyand manual null-termination inDataManager::Error.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| gframe/sound_manager.cpp | Swapped strcpy for std::strncpy + null-termination; updated snprintf to use sizeof. |
| gframe/data_manager.cpp | Replaced strncat error construction with std::strncpy + null-termination. |
Collaborator
|
need tool function |
Collaborator
Author
|
will change later |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We should avoid strcpy.
@mercury233
@purerosefallen